cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

disable standard confirmation emails if workflow exists

Open CarinaWolli opened this issue 2 years ago • 3 comments

What does this PR do?

Allow disabling standard confirmation emails for host and attendees if event type is active on a workflow that will send these emails instead.

The trigger EMAIL_ATTENDEE now sends emails to all attendees not just the first one.

Switches to disable emails can be found in advanced event type settings: Screenshot 2023-05-08 at 13 13 14

Fixes #3680

Loom: https://www.loom.com/share/f569f130746748ffaa6481a9536ba2e3

CarinaWolli avatar May 08 '23 09:05 CarinaWolli

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 7:03am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview May 9, 2023 7:03am

vercel[bot] avatar May 08 '23 09:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/event-types/[type] 468.7 KB 619.53 KB 177.01% (🟡 +5.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 08 '23 09:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 112 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/09/2023 07:18:21am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7e6d4eacf18bd2f75173cba0cb65ae40c667d859

Started: 05/09/2023 07:07:48am UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
5.06% (12) 12 / 237 runs
failed over last 7 days
22.78% (54) 54 / 237 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
4.38% (7) 7 / 160 runs
failed over last 7 days
8.75% (14) 14 / 160 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.test.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
16.11% (24) 24 / 149 runs
failed over last 7 days
63.76% (95) 95 / 149 runs
flaked over last 7 days

📄   apps/web/playwright/availability.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity tests Date Overrides
Retry 1Initial Attempt
2.76% (7) 7 / 254 runs
failed over last 7 days
1.57% (4) 4 / 254 runs
flaked over last 7 days
Availablity tests Availability pages
Retry 1Initial Attempt
0% (0) 0 / 253 runs
failed over last 7 days
1.58% (4) 4 / 253 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 08 '23 09:05 deploysentinel[bot]

Updated text: Screenshot 2023-05-09 at 08 55 51

CarinaWolli avatar May 09 '23 06:05 CarinaWolli

@CarinaWolli i mentioned this before, should the checkbox not be visible inside the workflows area?

PeerRich avatar May 09 '23 16:05 PeerRich

@CarinaWolli i mentioned this before, should the checkbox not be visible inside the workflows area?

@PeerRich to save Carina from having to repeat herself :) CleanShot 2023-05-09 at 18 02 26@2x (since I brought this up twice also 😂)

ciaranha avatar May 09 '23 17:05 ciaranha

ok merging when ready

PeerRich avatar May 09 '23 17:05 PeerRich