cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Fixes 8286 add search and pagination feature for users list

Open ManVTish opened this issue 2 years ago • 5 comments

What does this PR do?

Fixes #8286 This PR adds optional input for search & pagination and validated using Zod. The techniques for searching and pagination in Prisma documentation was taken as reference. https://www.prisma.io/docs/concepts/components/prisma-client refer pagination and filter/sort for reference.

The code has a FIXME section which I believe should have a separate PR to address. I have already started work for that part as well.

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

ManVTish avatar May 07 '23 17:05 ManVTish

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2023 5:58pm

vercel[bot] avatar May 07 '23 17:05 vercel[bot]

@ManVTish is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 07 '23 17:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 456.7 KB 607.48 KB 173.57% (🟡 +0.17%)
/auth/setup 174.65 KB 325.43 KB 92.98% (🟡 +0.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 07 '23 18:05 github-actions[bot]

Hey @Udit-takkar, thanks so much for reviewing my PR, really thankful to you for the pointers.

ManVTish avatar May 08 '23 11:05 ManVTish

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 23 '23 00:05 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jun 30 '23 00:06 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Jul 08 '23 00:07 github-actions[bot]