cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Published 20 hours ago • verified publisher icon calcom

Cancel button does not have border like SAVE button - in changing avatar dialog

Open mMARUF opened this issue 2 years ago • 11 comments

Issue Summary

Cancel button does not have border like SAVE button – in changing avatar dialog

Steps to Reproduce

  1. Go to cal.com
  2. Go to Settings
  3. Press on CHANGE AVATAR button
  4. Observe the Cancel button

Actual Result

Cancel button does not have border like SAVE button

Expected Result

Cancel button should have same border like SAVE button

Technical details

OS: MacOS Ventura 13.3.1 (a) Browser: Chrome 113.0.5672.63

Attachment

Screenshot 2023-05-07 at 2 54 06 PM

mMARUF avatar May 07 '23 09:05 mMARUF

@all, Can someone assign this bug to me.

Chandan9898Kumar avatar May 07 '23 10:05 Chandan9898Kumar

@mMARUF I think this is how it is supposed to be. @JeroenReumkens @sean-brydon can you please confirm this?

vaibhav135 avatar May 07 '23 10:05 vaibhav135

I think it looks good that way!

harshopes avatar May 07 '23 10:05 harshopes

It does look good from an aesthetic standpoint, but wouldn't it be good if all the elements (or buttons) follow a consistent guideline?

rohannair11 avatar May 07 '23 10:05 rohannair11

I would like to work on this. Can assign it to me

Ash9311 avatar May 07 '23 11:05 Ash9311

I think its look good without border

17rawat avatar May 07 '23 14:05 17rawat

I think , It's not a bug This cancel button was created in this particular way.

And If not , Can Someone assign this issue to me , As it seems a easy fix to me and I'm new to this Open-source community

Any Kind of help would be appreciated.

kshitiz-goel07 avatar May 07 '23 15:05 kshitiz-goel07

image

@mMARUF is this is how you want it to be.

Aytida-dev avatar May 07 '23 15:05 Aytida-dev

@Aytida-dev yes. Same border in both the buttons.

mMARUF avatar May 07 '23 15:05 mMARUF

Follow the figma design guidline if it's in there with border with both button then you may consider it as a bug other wise i don't think it's a bug 🐛 design.cal.com

rahilansari261 avatar May 07 '23 16:05 rahilansari261

It is fixed @mMARUF Please Close this issue.

Praashh avatar May 07 '23 17:05 Praashh

@mMARUF I think this is how it is supposed to be. @JeroenReumkens @sean-brydon can you please confirm this?

It is indeed how it's supposed to be. The save action is the primary action, and the cancel is secondary. That's why they look different, to also distinguish this visually. Thanks a lot for creating to issue @mMARUF, I am however gonna close this now because it looks the way it should be 😁

JeroenReumkens avatar May 08 '23 12:05 JeroenReumkens