cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

implemented async using queue data structure

Open ManVTish opened this issue 2 years ago • 3 comments

What does this PR do?

Fixes #8345

This PR implements a queue data structure to sequentially process each credential rather than using Promise.all. However the logic is kept same for sendDisabledAppEmail process.

Environment: Staging(main branch) / Production

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

ManVTish avatar May 06 '23 18:05 ManVTish

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 5:44pm

vercel[bot] avatar May 06 '23 18:05 vercel[bot]

@ManVTish is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 06 '23 18:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 06 '23 18:05 github-actions[bot]

Thanks for this @ManVTish - however the comment was a bit vague on what should be made async. the async bit is talking about queueing emails rather than the call to the email. Sorry about the confusion, this logic should remain promise.all but the email system in entirety should be async.

emrysal avatar May 10 '23 07:05 emrysal