cal.com
cal.com copied to clipboard
calcom
resolveEndpoint function is made readable
What does this PR do?
Fixes #8709 This PR is an attempt to refactor the resolveEndpoint function which maps the path to correct endpoints, and make it more readable.
Environment: Staging(main branch) / Production
Type of change
- Chore (refactoring code,)
@ManVTish is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 1, 2023 4:30am |
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 1, 2023 4:30am |
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I understand the ENDPOINT needs to be made dynamic, but that's opened as different issue. However, could you give me some hint on what needs to be addressed? Thank you @hariombalhara for reviewing my PR. Really appreciate your detailed feedback.
@ManVTish When cold starts were fixed as part of #8041, a larger refactor to remove "viewer" from all of the UI code was not done. Hence, this endpoint parsing code was introduced. The ultimate fix is to actually update all of the UI components that call tRPC and point them directly to the new tRPC routes. However, that's a much larger change. Your refactor here is still helpful to make this parsing read better but we need to leave the TODO in place.
This PR is being closed due to inactivity. Please reopen if work is intended to be continued.