cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: Rounding, frames and radio buttons of the booking forms not consistent

Open gitstart-calcom opened this issue 1 year ago • 10 comments

Fixes #7508

Demo

https://www.loom.com/share/f020b84243ca48928f6d44d8b9df6f92

Steps to reproduce:

  1. Edit some event-type
  2. Click on advanced settings and add all the options
  3. Go to settings/appearance and change the brand color
  4. Try to schedule some meeting

FIgma with the updated design: https://www.figma.com/file/9MOufQNLtdkpnDucmNX10R/%E2%9D%96-Cal-DS?node-id=309-44674&t=XVOdTk8kjKnXp6ti-0

gitstart-calcom avatar May 05 '23 15:05 gitstart-calcom

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 3:16pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 3:16pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Visit Preview May 30, 2023 3:16pm

vercel[bot] avatar May 05 '23 15:05 vercel[bot]

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] eval +2 bl00mber

socket-security[bot] avatar May 05 '23 15:05 socket-security[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twelve Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 254.86 KB 406.03 KB 116.01% (🟢 -0.41%)
/apps/[slug]/[...pages] 458.95 KB 610.12 KB 174.32% (🟡 +0.25%)
/auth/setup 174.84 KB 326.01 KB 93.15% (🟡 +0.16%)
/bookings/[status] 341.19 KB 492.36 KB 140.67% (🟢 -0.28%)
/d/[link]/book 254.51 KB 405.68 KB 115.91% (🟢 -0.41%)
/event-types 427.44 KB 578.6 KB 165.32% (🟢 -0.40%)
/getting-started/[[...step]] 426.23 KB 577.4 KB 164.97% (🟢 -0.22%)
/new-booker/[user]/[type] 290.13 KB 441.29 KB 126.08% (🟢 -0.40%)
/new-booker/team/[slug]/[type] 290.13 KB 441.3 KB 126.09% (🟢 -0.41%)
/settings/my-account/calendars 252.32 KB 403.49 KB 115.28% (🟢 -0.22%)
/team/[slug]/book 254.51 KB 405.68 KB 115.91% (🟢 -0.41%)
/workflows/[workflow] 367.99 KB 519.16 KB 148.33% (🟢 -0.28%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 05 '23 15:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 104 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/30/2023 03:43:35pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 59236cf4a37b201867460aa8b04b695bf3447893

Started: 05/30/2023 03:39:08pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user -- new-booker can add multiple organizer address
Retry 1Initial Attempt
2.30% (9) 9 / 392 runs
failed over last 7 days
11.48% (45) 45 / 392 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
2.78% (4) 4 / 144 runs
failed over last 7 days
65.28% (94) 94 / 144 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 05 '23 15:05 deploysentinel[bot]

Hi @sean-brydon @PeerRich, PR has been updated, please take a look https://www.loom.com/share/f020b84243ca48928f6d44d8b9df6f92

gitstart-calcom avatar May 11 '23 09:05 gitstart-calcom

LGTM NITs dont need to be adressed but it would be ideal :)

Just waiting for yarn.lock to be removed from this PR

are you sure tho? We're adding a new package

PeerRich avatar May 12 '23 12:05 PeerRich

ALso apologies i didnt realise there was a new package being added here! Looks like we may need the lock file after all! Sorry!

sean-brydon avatar May 16 '23 10:05 sean-brydon

Added the lock file back and also made the requested changes @sean-brydon

gitstart-calcom avatar May 16 '23 12:05 gitstart-calcom

@gitstart @zomars This phone input issue seems to be related to an overflow issue that I also had when making the booker work as an embed. I fixed it in that (draft) PR: #9023

For now it's safe to ignore the overflow issue. I will test it once that PR is merged and make sure it works, and fix it otherwise ❤️

JeroenReumkens avatar May 22 '23 06:05 JeroenReumkens

@gitstart @zomars This phone input issue seems to be related to an overflow issue that I also had when making the booker work as an embed. I fixed it in that (draft) PR: #9023

For now it's safe to ignore the overflow issue. I will test it once that PR is merged and make sure it works, and fix it otherwise ❤️

Hi @zomars, what do you think?

gitstart-calcom avatar May 23 '23 17:05 gitstart-calcom