cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Issue:8652: Fixed slot link button issue

Open HeratPatel opened this issue 1 year ago • 6 comments

What does this PR do?

Fixes #8652

https://user-images.githubusercontent.com/22561658/236470807-5522a12c-4756-4839-afc3-5ce0a6a33e27.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@kanakpandit17

HeratPatel avatar May 05 '23 13:05 HeratPatel

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 05 '23 13:05 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 1:41pm

vercel[bot] avatar May 05 '23 13:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 05 '23 13:05 github-actions[bot]

@JeroenReumkens is this still an issue in the new booker or do we automatically transition ?

sean-brydon avatar May 05 '23 14:05 sean-brydon

In New booker it is instant transition. So, this problem isn't there AFAIK.

hariombalhara avatar May 06 '23 12:05 hariombalhara

@sean-brydon Correct, this isn't an issue anymore in the new booker, it instantly goes to the next step, no loading/pending state.

JeroenReumkens avatar May 08 '23 12:05 JeroenReumkens

Hey @HeratPatel

Thanks a lot for your contribution! As stated above we are currently working on rebuilding our booker, which combines both of the pages in a single page. So this issue will be automatically resolved in the new booker. Therefore I'm going to close this PR — it doesn't make a lot of sense to keep building these new features in the booker current, since it will be replaced soon.

Thanks again for your contribution, it's really appreciated.

— Jeroen.

JeroenReumkens avatar May 11 '23 06:05 JeroenReumkens