cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

CalDav (Beta) icon should be inverted in Dark theme

Open Shubhdeep12 opened this issue 1 year ago • 3 comments

Found a bug? Please fill out the sections below. 👍

CalDav (Beta) icon should be inverted in the Dark theme

image

A summary of the issue. This needs to be a clear detailed-rich summary.

Steps to Reproduce

  1. Select Dark Theme
  2. Go to Apps

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

  • Browser version, screen recording, console logs, network requests: You can make a recording with Bird Eats Bug.
  • Node.js version
  • Anything else that you think could be an issue.

Shubhdeep12 avatar May 05 '23 08:05 Shubhdeep12

Let me know if this is valid issue, would love to work on this. Thanks

Shubhdeep12 avatar May 05 '23 08:05 Shubhdeep12

Yes this is valid issue

Praashh avatar May 05 '23 08:05 Praashh

Ohh then no need to fix it please close it

On Fri, 5 May, 2023, 4:14 PM Pawan Kishor Singh, @.***> wrote:

Seems like this issue is already fixed.

[image: Screenshot 2023-05-05 at 4 13 04 PM] https://user-images.githubusercontent.com/32010243/236437839-ac1409fe-517a-4c74-b771-662e078a3f8d.png

— Reply to this email directly, view it on GitHub https://github.com/calcom/cal.com/issues/8686#issuecomment-1536068542, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVD7I2R2SMN5BQR2SOIQILXETKZ3ANCNFSM6AAAAAAXWZNU54 . You are receiving this because you commented.Message ID: <calcom/cal. @.***>

Praashh avatar May 05 '23 12:05 Praashh

This issue related to #8111 And it is resolved as of now They have added a condition for caldav app specifically. Screenshot_2023-05-06-23-45-57-03_40deb401b9ffe8e1df2f1cc5ba480b12

rahilansari261 avatar May 06 '23 18:05 rahilansari261

But this is not a bug I thing everything is pretty fine

On Sat, 6 May, 2023, 11:51 PM Rahil Ansari, @.***> wrote:

This issue related to #8111 https://github.com/calcom/cal.com/issues/8111 And it is resolved as of now They have added a condition for caldav app specifically. [image: Screenshot_2023-05-06-23-45-57-03_40deb401b9ffe8e1df2f1cc5ba480b12] https://user-images.githubusercontent.com/12849916/236640605-51ff0c76-fc0d-4cba-9cb7-f57916fffc7d.jpg

— Reply to this email directly, view it on GitHub https://github.com/calcom/cal.com/issues/8686#issuecomment-1537196274, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVD7I7AMXUZYGDHKSKCDVTXE2JA7ANCNFSM6AAAAAAXWZNU54 . You are receiving this because you commented.Message ID: <calcom/cal. @.***>

Praashh avatar May 06 '23 18:05 Praashh

@9520prashant agreed :)

rahilansari261 avatar May 07 '23 04:05 rahilansari261

Great 👍🏻

On Sun, 7 May, 2023, 11:11 AM Shubhdeep Chhabra, @.***> wrote:

Closed #8686 https://github.com/calcom/cal.com/issues/8686 as completed.

— Reply to this email directly, view it on GitHub https://github.com/calcom/cal.com/issues/8686#event-9183676097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXVD7I3Y34AR34OQUJUJU43XE4YXHANCNFSM6AAAAAAXWZNU54 . You are receiving this because you were mentioned.Message ID: <calcom/cal. @.***>

Praashh avatar May 07 '23 05:05 Praashh