cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

CAL-1554: remove gap between form and event meta on now booker

Open JeroenReumkens opened this issue 1 year ago • 4 comments

What does this PR do?

Removes gap between form and event meta on now booker due to css grid alignment. Grid made all rows have equal height instead of auto height. That's now changed in this PR.

Before: CleanShot 2023-05-04 at 12 54 16@2x

After: CleanShot 2023-05-04 at 12 53 53@2x

Fixes #8321

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • [ ] Open the mobile view of the new booker (first view - small calendar), then select a date + timeslot, then zoom out a bit on mobile, then the form shouldn't be aligned halfway on the page anymore.
  • [ ] Ensure the desktop view isn't broken now either.

JeroenReumkens avatar May 04 '23 11:05 JeroenReumkens

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 0:27am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 0:27am

vercel[bot] avatar May 04 '23 11:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 04 '23 12:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/05/2023 12:37:46pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 869169f9db9239ed2b8e6e769e3b444db98ca953

Started: 05/05/2023 12:27:40pm UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types tests Can create managed event type
Retry 1Initial Attempt
2.84% (5) 5 / 176 runs
failed over last 7 days
18.18% (32) 32 / 176 runs
flaked over last 7 days

📄   apps/web/playwright/app-store.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
App Store - Authed Browse apple-calendar and try to install
Retry 1Initial Attempt
0% (0) 0 / 219 runs
failed over last 7 days
57.08% (125) 125 / 219 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 04 '23 12:05 deploysentinel[bot]