cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: add canonical to the document via `PageWrapper`

Open p6l-richard opened this issue 1 year ago • 3 comments

What does this PR do?

Fixes Duplicate without user-selected canonical issue in google search console: CleanShot 2023-05-03 at 15 21 13 CleanShot 2023-05-03 at 15 22 26

Demo

CleanShot 2023-05-03 at 15 23 28

Environment: Production

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • [ ] Check the dev tools network tab and see if the document includes the canonical link

p6l-richard avatar May 03 '23 13:05 p6l-richard

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 6:24pm
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 6:24pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2023 6:24pm

vercel[bot] avatar May 03 '23 13:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twelve Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 255.64 KB 406.86 KB 116.24% (🟡 +0.19%)
/apps/[slug]/[...pages] 458.5 KB 609.72 KB 174.21% (🟢 -0.23%)
/apps/installed/[category] 278.69 KB 429.9 KB 122.83% (🟡 +0.15%)
/d/[link]/book 255.29 KB 406.5 KB 116.14% (🟡 +0.19%)
/event-types 428.3 KB 579.52 KB 165.58% (🟡 +0.15%)
/event-types/[type] 479.12 KB 630.33 KB 180.10% (🟢 -0.16%)
/getting-started/[[...step]] 427.23 KB 578.45 KB 165.27% (🟡 +0.27%)
/new-booker/[user]/[type] 290.83 KB 442.05 KB 126.30% (🟡 +0.17%)
/new-booker/d/[link]/[slug] 290.83 KB 442.05 KB 126.30% (🟡 +0.17%)
/new-booker/team/[slug]/[type] 290.84 KB 442.05 KB 126.30% (🟡 +0.17%)
/settings/my-account/calendars 253.49 KB 404.71 KB 115.63% (🟡 +0.26%)
/team/[slug]/book 255.29 KB 406.5 KB 116.14% (🟡 +0.19%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 03 '23 13:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 106 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/02/2023 06:27:59pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a294f129568077ba1ae44446e75a17d9ca7ecba5

Started: 06/02/2023 06:25:38pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
1.08% (2) 2 / 186 runs
failed over last 7 days
6.45% (12) 12 / 186 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
3.76% (7) 7 / 186 runs
failed over last 7 days
88.17% (164) 164 / 186 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 241 runs
failed over last 7 days
9.96% (24) 24 / 241 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 03 '23 13:05 deploysentinel[bot]

@roae can you adjust your review?

PeerRich avatar Jun 02 '23 18:06 PeerRich