cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Published 20 hours ago • verified publisher icon calcom

Closes #1847 - adds env variable `JITSI_HOST_URL`

Open chief-nerd opened this issue 1 year ago • 7 comments

What does this PR do?

Fixes #1847 and #6262 - adds an environment variable JITSI_HOST_URL to configure the Host URL for self hosted instances

Environment: Staging(main branch) / Production

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How should this be tested?

  • [ ] Set ENV JITSI_HOST_URL
  • [ ] Schedule a meeting with Location: Jitis
  • [ ] URL should be the self-hosted instance

Checklist

  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

chief-nerd avatar May 03 '23 09:05 chief-nerd

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 5:12am

vercel[bot] avatar May 03 '23 09:05 vercel[bot]

@chief-nerd is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 03 '23 09:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 03 '23 09:05 github-actions[bot]

PR Update / Linters / lint (pull_request_target) ✖ fatal 4 errors and 96 warnings

... but they are not coming from THIS pull request. :)

chief-nerd avatar May 03 '23 14:05 chief-nerd

@chief-nerd i have re triggered them

Udit-takkar avatar May 03 '23 20:05 Udit-takkar

If you are looking for a quick fix (assume running the Docker version): docker compose exec -it calcom /calcom/scripts/replace-placeholder.sh meet.jit.si meet.mydomain.com

chief-nerd avatar May 03 '23 20:05 chief-nerd

Hey @chief-nerd I think the issue is just some linting issues around using tabs instead of spaces for the modified lines (probably some defaults from your IDE)

Also was missing to add in turbo.json the jitsu env var

Deployed a PR with the fixes here in case it helps https://github.com/calcom/cal.com/pull/8681

agustif avatar May 04 '23 21:05 agustif

🎉 -- so looking forward to finally (officially) using this

chief-nerd avatar May 10 '23 08:05 chief-nerd