cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1296]: Merge Multiselectcheckbox with Select component

Open ExplorerAadi opened this issue 2 years ago • 6 comments

What does this PR do?

Fixes #7836

Loom Video: https://www.loom.com/share/285058935540490794e2767f17726724

Environment: Staging(main branch) / Production

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • [ ] Test A
  • [ ] Test B

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

ExplorerAadi avatar May 02 '23 16:05 ExplorerAadi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2023 4:19pm

vercel[bot] avatar May 02 '23 16:05 vercel[bot]

@ExplorerAadi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 02 '23 16:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 02 '23 16:05 github-actions[bot]

Thanks for the contribtion @ExplorerAadi - few NITs and things we could improve on :)

Hey @sean-brydon I have fixed the bundle size issue as well as moved the translation to the workflow component. Apologies for my earlier commit where I did not check properly that it broke things. Here is the loom recording of my updated branch: https://www.loom.com/share/9ef8abd9c1c24ecd934ae61faaafb4c8

ExplorerAadi avatar May 08 '23 17:05 ExplorerAadi

hey @ExplorerAadi there are some merge conflicts, can you investigate?

PeerRich avatar May 17 '23 18:05 PeerRich

hey @PeerRich thanks for flagging this, I have rebased the PR with the main branch.

ExplorerAadi avatar May 23 '23 16:05 ExplorerAadi

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jul 01 '23 00:07 github-actions[bot]

hey @PeerRich thanks for flagging this, I have rebased the PR with the main branch.

So sorry for the delay - this got lost in my inbox. Would you be able to fix the E2E tests that are failing on this PR?

Codewise this looks pretty good @ExplorerAadi

sean-brydon avatar Jul 03 '23 09:07 sean-brydon

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jul 25 '23 00:07 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

keithwillcode avatar Jul 25 '23 15:07 keithwillcode