cal.com
cal.com copied to clipboard
[CAL-1296]: Merge Multiselectcheckbox with Select component
What does this PR do?
Fixes #7836
Loom Video: https://www.loom.com/share/285058935540490794e2767f17726724
Environment: Staging(main branch) / Production
Type of change
- Chore (refactoring code, technical debt, workflow improvements)
How should this be tested?
- [ ] Test A
- [ ] Test B
Checklist
- I haven't added tests that prove my fix is effective or that my feature works
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 23, 2023 4:19pm |
@ExplorerAadi is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
Thanks for the contribtion @ExplorerAadi - few NITs and things we could improve on :)
Hey @sean-brydon I have fixed the bundle size issue as well as moved the translation to the workflow component. Apologies for my earlier commit where I did not check properly that it broke things. Here is the loom recording of my updated branch: https://www.loom.com/share/9ef8abd9c1c24ecd934ae61faaafb4c8
hey @ExplorerAadi there are some merge conflicts, can you investigate?
hey @PeerRich thanks for flagging this, I have rebased the PR with the main branch.
This PR is being marked as stale due to inactivity.
hey @PeerRich thanks for flagging this, I have rebased the PR with the main branch.
So sorry for the delay - this got lost in my inbox. Would you be able to fix the E2E tests that are failing on this PR?
Codewise this looks pretty good @ExplorerAadi
This PR is being marked as stale due to inactivity.
This PR is being closed due to inactivity. Please reopen if work is intended to be continued.