cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Profile picture does not update on the left sidebar

Open oneknucklehead opened this issue 1 year ago • 17 comments

Found a bug? Please fill out the sections below. 👍

Issue Summary

The profile picture does not update on the leftside navbar even though the profile picture has been updated already and the page has been refreshed continuously.

Screenshot 2023-05-02 012913

Steps to Reproduce

  1. Go to https://app.cal.com/settings/my-account/profile
  2. try updating your profile picture

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

  • Browser version, screen recording, console logs, network requests: You can make a recording with Bird Eats Bug.
  • Node.js version
  • Anything else that you think could be an issue.

oneknucklehead avatar May 01 '23 20:05 oneknucklehead

Hi, I know how to solve this issue. What's happening here is that the image data from the navbar is set to a source that gets data on the user login. Hence, when you sign out and again sign in, fresh data is stored and now the sidebar will have new data (image). Kindly assign this issue to me, and I can help you solve it.

Also, there were some UI changes. Like, in the profile settings section, there must be an edit button, which users can click on to edit their profile. Until the edit button is clicked, the profile data must be read-only. Also, when the "Update" button is clicked message 'Profile updated successfully' should be displayed and the profile should go back to read-only. Do you this is a good idea?

loki1205 avatar May 02 '23 00:05 loki1205

@oneknucklehead I have reproduced the bug that you have mentioned above , but the profile picture is updating on the sidebar too. Here is the scree Screenshot 2023-05-02 at 12-08-08 Profile Cal com nshot ..

ujjwal-45 avatar May 02 '23 06:05 ujjwal-45

@oneknucklehead I have reproduced the bug that you have mentioned above , but the profile picture is updating on the sidebar too. Here is the scree Screenshot 2023-05-02 at 12-08-08 Profile Cal com nshot ..

Sorry, I didn't understand. Is this on localhost? Or on the server, https://app.cal.com/settings/my-account/profile. Do you mean, you have fixed the bug or that the bug is not showing up for you?

loki1205 avatar May 02 '23 06:05 loki1205

Yes, this is on localhost and the bug is not showing.

ujjwal-45 avatar May 02 '23 08:05 ujjwal-45

Yes, this is on localhost and the bug is not showing.

Did you try it on https://app.cal.com/settings/my-account/profile? If not, create an account on cal.com and then try updating the profile picture. You should face the issue.

loki1205 avatar May 02 '23 08:05 loki1205

can you assign me to this issue and thanks

ajaxbo360 avatar May 02 '23 15:05 ajaxbo360

@loki1205 , i have created an account on cal.com and updated my profile but I am still not getting the bug. I have refreshed it one or two times. Screenshot 2023-05-02 at 21-17-46 Profile Cal com

ujjwal-45 avatar May 02 '23 15:05 ujjwal-45

same here @ujjwal-45

ajaxbo360 avatar May 02 '23 17:05 ajaxbo360

Screenshot 2023-05-02 225803

Hey! @loki1205 The bug is also showing to me on the live version. I have created new account and gone through profile page and the blank avtar image shows up.

Himanshu2561 avatar May 02 '23 17:05 Himanshu2561

did you refresh the page @Himanshu2561

ajaxbo360 avatar May 02 '23 17:05 ajaxbo360

yes @ajaxbo360

Himanshu2561 avatar May 02 '23 17:05 Himanshu2561

i don’t see any issue regarding profile pic everything is working fine for me @Himanshu2561

ajaxbo360 avatar May 02 '23 18:05 ajaxbo360

Try creating a new account @ajaxbo360

Himanshu2561 avatar May 02 '23 18:05 Himanshu2561

i tried creating a new account still didn’t see any bug @Himanshu2561

ajaxbo360 avatar May 02 '23 18:05 ajaxbo360

I also don't see any issue , all is working fine thanks.

MBWankhade avatar May 02 '23 19:05 MBWankhade

I guess the issue of not updating the profile picture in the sidebar is before doing a refresh, when we update the profile image the data in the sidebar becomes stale, we need to explicitly revalidate it when the profile picture gets updated, I hope that will fix this issue :) Anyway This is mentioned in issue #8567

zeeshanbhati avatar May 02 '23 21:05 zeeshanbhati

image

Somehow I was able to reproduce the issue

mrb1nary avatar May 04 '23 12:05 mrb1nary

This was fixed in #8570

keithwillcode avatar Aug 16 '23 12:08 keithwillcode