cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Add HistoryPlugin to the Editor UI component

Open Praneeth2k opened this issue 1 year ago • 3 comments

What does this PR do?

Fixes https://github.com/calcom/cal.com/issues/8602 Adds the HistoryPlugin to the Editor component to enable undoing(ctrl+z) and redoing(ctrl+shift+z)

Environment: Staging(main branch) / Production

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • [x] Checked the Editor section, was able to undo/redo changes after adding the HistoryPlugin
  • [x] yarn test-e2e

Checklist

Praneeth2k avatar May 01 '23 15:05 Praneeth2k

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 2:15pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 2:15pm

vercel[bot] avatar May 01 '23 15:05 vercel[bot]

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 01 '23 15:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 456.69 KB 607.13 KB 173.47% (🟡 +0.16%)
/auth/setup 174.6 KB 325.04 KB 92.87% (🟡 +0.16%)
/event-types 415.29 KB 565.73 KB 161.64% (🟡 +0.32%)
/event-types/[type] 451.23 KB 601.67 KB 171.91% (🟡 +0.30%)
/getting-started/[[...step]] 382.52 KB 532.96 KB 152.27% (🟡 +0.32%)
/settings/my-account/profile 361.84 KB 512.28 KB 146.37% (🟡 +0.32%)
/settings/teams/[id]/profile 357.18 KB 507.62 KB 145.04% (🟡 +0.31%)
/workflows/[workflow] 357.65 KB 508.1 KB 145.17% (🟡 +0.32%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 01 '23 15:05 github-actions[bot]

@Udit-takkar Thanks for approving. I'm a bit fuzzy about what the next step is. I believe I need to wait for an approval from calcom/ui. I see that some tests have failed, should I be fixing them? It doesn't seem like those failures are related to my change.

Praneeth2k avatar May 02 '23 06:05 Praneeth2k

@Praneeth2k i'll retrigger the tests

Udit-takkar avatar May 02 '23 09:05 Udit-takkar