Fix: Show smsReminderNumber on booking success page

[hariombalhara]

trafficstars

What does this PR do?

Fixes #8380 Fixes CAL-1607 A PR was initially created by @Hallidayo which implements the fix but some changes were requested which are not yet done yet. So, I am taking over the bug fix.

Before:

After:

Environment: Production

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• [x] Enable a workflow(with action that sends SMS to attendee) in an event-type. Fill up the automatically added SMS Reminder Number field in the booking form. Expect that the smsReminderNumber is shown as in above screenshot

Checklist

• I haven't added tests that prove my fix is effective or that my feature works

[linear[bot]]

CAL-1607 Additional question (phone number) not showing in the email

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 2, 2023 4:40pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
ui	⬜️ Ignored (Inspect)	Visit Preview		May 2, 2023 4:40pm

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/availability/[schedule]	330.43 KB	480.88 KB	137.39% (🟡 +9.10%)
/event-types	414.17 KB	564.62 KB	161.32% (🟢 -0.32%)
/event-types/[type]	450.12 KB	600.57 KB	171.59% (🟢 -0.32%)
/getting-started/[[...step]]	413.22 KB	563.67 KB	161.05% (🟡 +8.77%)
/settings/admin/users/[id]/edit	331.87 KB	482.32 KB	137.81% (🟡 +9.09%)
/settings/admin/users/add	331.55 KB	482 KB	137.71% (🟡 +9.09%)
/settings/my-account/general	325.39 KB	475.84 KB	135.96% (🟡 +9.09%)
/settings/my-account/profile	360.72 KB	511.17 KB	146.05% (🟢 -0.32%)
/settings/teams/[id]/members	356.8 KB	507.25 KB	144.93% (🟡 +9.09%)
/settings/teams/[id]/profile	356.06 KB	506.51 KB	144.72% (🟢 -0.32%)
/workflows/[workflow]	356.53 KB	506.98 KB	144.85% (🟢 -0.32%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 112 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/02/2023 04:57:49pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 5f08dbd810c365d6b6c19bc44996f48fc6a86938

Started: 05/02/2023 04:42:41pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type Retry 1 • Initial Attempt	2.73% (5) 5 / 183 runs failed over last 7 days	21.31% (39) 39 / 183 runs flaked over last 7 days

---

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
pro user -- new-booker Can cancel the recently created booking and rebook the same timeslot Retry 2 • Retry 1 • Initial Attempt	1.06% (2) 2 / 188 runs failed over last 7 days	2.13% (4) 4 / 188 runs flaked over last 7 days

---

📄   apps/web/playwright/app-store.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
App Store - Authed Browse apple-calendar and try to install Retry 1 • Initial Attempt	1.02% (2) 2 / 197 runs failed over last 7 days	42.13% (83) 83 / 197 runs flaked over last 7 days

---

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 1 • Initial Attempt	2.82% (4) 4 / 142 runs failed over last 7 days	2.82% (4) 4 / 142 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/action-based.test.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	13.08% (17) 17 / 130 runs failed over last 7 days	43.08% (56) 56 / 130 runs flaked over last 7 days

---

View Detailed Build Results

---