cal.com
cal.com copied to clipboard
perf: cache i18n response
What does this PR do?
this PR aims to cache the i18n response rather than re-returning the same object using http-cache
Environment: Staging(main branch) / Production
Type of change
- New feature (non-breaking change which adds functionality)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 23, 2023 11:02am |
ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 23, 2023 11:02am |
New dependency changes detected. Learn more about Socket for GitHub ↗︎
👍 No new dependency issues detected in pull request
Bot Commands
To ignore an alert, reply with a comment starting with @SocketSecurity ignore
followed by a space separated list of package-name@version
specifiers. e.g. @SocketSecurity ignore [email protected] bar@*
or ignore all packages with @SocketSecurity ignore-all
Pull request alert summary
Issue | Status |
---|---|
Install scripts | ✅ 0 issues |
Native code | ✅ 0 issues |
Bin script shell injection | ✅ 0 issues |
Unresolved require | ✅ 0 issues |
Invalid package.json | ✅ 0 issues |
HTTP dependency | ✅ 0 issues |
Git dependency | ✅ 0 issues |
Potential typo squat | ✅ 0 issues |
Known Malware | ✅ 0 issues |
Telemetry | ✅ 0 issues |
Protestware/Troll package | ✅ 0 issues |
📊 Modified Dependency Overview:
➕ Added Package | Capability Access | +/- Transitive Count |
Publisher |
---|---|---|---|
[email protected] | None | +1 |
jjenzz |
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load | % of Budget (350 KB ) |
---|---|---|---|
/[user]/book |
256.11 KB |
407.09 KB | 116.31% (🟡 +0.15%) |
/auth/setup |
174.25 KB |
325.24 KB | 92.92% (🟢 -0.14%) |
/d/[link]/book |
255.75 KB |
406.74 KB | 116.21% (🟡 +0.15%) |
/new-booker/[user]/[type] |
291.2 KB |
442.18 KB | 126.34% (🟡 +0.15%) |
/new-booker/team/[slug]/[type] |
291.2 KB |
442.19 KB | 126.34% (🟡 +0.15%) |
/team/[slug]/book |
255.76 KB |
406.74 KB | 116.21% (🟡 +0.15%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
Current Playwright Test Results Summary
✅ 114 Passing - ⚠️ 4 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 05/23/2023 11:22:09am UTC)
Run Details
Running Workflow PR Update on Github Actions
Commit: cdda22b2b631f42b09ddf955b7e472b3e9e753d4
Started: 05/23/2023 11:06:52am UTC
⚠️ Flakes
📄 apps/web/playwright/reschedule.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Reschedule Tests -- old-booker Paid rescheduling should go to success page
Retry 1 • Initial Attempt |
0% (0)0 / 318 runsfailed over last 7 days |
1.26% (4)4 / 318 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Event Types tests user -- old-booker enabling recurring event comes with default options
Retry 1 • Initial Attempt |
0% (0)0 / 336 runsfailed over last 7 days |
2.08% (7)7 / 336 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
2 Test Cases Affected |
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 345 runsfailed over last 7 days |
84.93% (293)293 / 345 runsflaked over last 7 days |
Booking with Seats -- old-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 343 runsfailed over last 7 days |
20.12% (69)69 / 343 runsflaked over last 7 days |
i think @hariombalhara mentioned sometime before that he faced some issue while trying to cache i18n on vercel.
Closing for now