cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[chore]: Replace color functions

Open SohamRatnaparkhi opened this issue 2 years ago • 6 comments

What does this PR do?

This PR uses the polished package (link) in

  • rgbToHex()
  • lighten()
  • darken()
  • getContrast()

Fixes #8560

Environment: Production

Type of change

  • Chore
  • This change requires a documentation update

How should this be tested?

Checklist

  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings

SohamRatnaparkhi avatar Apr 30 '23 18:04 SohamRatnaparkhi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 6:13pm

vercel[bot] avatar Apr 30 '23 18:04 vercel[bot]

@SohamRatnaparkhi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 30 '23 18:04 vercel[bot]

I have made this PR with the first changes that I felt should be made.

  1. The function rgbToHex() is going unused, but I haven't currently removed it (waiting for your suggestion on it).
  2. The functions lighten and darken, clash with the current code functions and hence I have currently made alias for the published package functions.

As I was not sure with my changes, I am awaiting your suggestions on them. Finally if required I will rebase these multiple commits and keep 1 final commit having correct changes.

SohamRatnaparkhi avatar Apr 30 '23 18:04 SohamRatnaparkhi

The reason for the test failure has been mentioned here -> link. Please do check that out for more information regarding failing tests.

SohamRatnaparkhi avatar Apr 30 '23 19:04 SohamRatnaparkhi

Thanks for the contribution @SohamRatnaparkhi - I actually have no clue why this doesnt work. I really expected it work better than my hacky functions :P

sean-brydon avatar May 05 '23 15:05 sean-brydon

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 20 '23 00:05 github-actions[bot]