cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Fix: Profile update refresh issues

Open Keyurkd opened this issue 1 year ago • 6 comments

What does this PR do?

Fixes #8567 #8610

Type of change

  • Bug fix Query the user profile & avatar data from the database and refresh the content of the left navbar.

Keyurkd avatar Apr 29 '23 23:04 Keyurkd

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2023 0:20am

vercel[bot] avatar Apr 29 '23 23:04 vercel[bot]

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 29 '23 23:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 174.07 KB 324.97 KB 92.85% (🟢 -0.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 29 '23 23:04 github-actions[bot]

Hey @Keyurkd This was a neat solution, but I believe you need to implement the same fix for the sidebar as well. I updated my profile picture but as you can see, it did not update here. image

ExplorerAadi avatar Apr 30 '23 06:04 ExplorerAadi

Hi @ExplorerAadi Check the updates on PR that will resolve the issue you've mentioned.

Keyurkd avatar Apr 30 '23 15:04 Keyurkd

Hi @zomars, @sean-brydon , Please review this PR.

Keyurkd avatar Apr 30 '23 15:04 Keyurkd

it feels like there is an easier fix for this. @zomars any ideas?

PeerRich avatar May 14 '23 21:05 PeerRich

it feels like there is an easier fix for this. @zomars any ideas?

Agreed. Can't we just invalidate the used query on the sidebar whenever updating the profile?

zomars avatar May 19 '23 21:05 zomars