cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Remove redirection after app uninstalltion

Open zeeshanbhati opened this issue 1 year ago • 3 comments

What does this PR do?

So When an app was uninstalled it used to redirect to apps/installed This PR makes sure that if it's uninstalled from route app/[appName] it does not redirect and stays as it is. Still need feedback if this behavior needs to be implemented on an app install as well.

Fixes #8554

Loom Video : https://www.loom.com/share/98a370e17ee54a87a0e33f8c8bac3d32

Environment: Staging(main branch) / Production

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • [ ] Test A
  • [ ] Test B

Checklist

  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

zeeshanbhati avatar Apr 27 '23 23:04 zeeshanbhati

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 9:33am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 9:33am

vercel[bot] avatar Apr 27 '23 23:04 vercel[bot]

@zeeshanbhati is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 27 '23 23:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 191.31 KB 341.74 KB 97.64% (🟡 +0.16%)
/event-types/[type] 466.9 KB 617.34 KB 176.38% (🟡 +0.20%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 27 '23 23:04 github-actions[bot]