cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1601] Component: App store card in event types should be using list-item component

Open ciaranha opened this issue 2 years ago • 5 comments

Currently these cards don't match design. We have a component built we can use for this.

Currently

CleanShot 2023-04-27 at 19.38.46@2x.png

Should be

CleanShot 2023-04-27 at 19.40.43@2x.png

View in Figma

From SyncLinear.com | CAL-1601

ciaranha avatar Apr 27 '23 17:04 ciaranha

@Jaibles - can I take this one?

Hallidayo avatar Apr 27 '23 18:04 Hallidayo

@Hallidayo go for it!

@sean-brydon would the component you built be ready for use here?

ciaranha avatar Apr 27 '23 18:04 ciaranha

@Hallidayo go for it!

@sean-brydon would the component you built be ready for use here?

It should be ... But its not even merged...

sean-brydon avatar Apr 28 '23 07:04 sean-brydon

@Jaibles - can I take this one?

Hey bud - I have a dead PR doing the majority of this https://github.com/calcom/cal.com/pull/7240 I don't currently have time to revive it from being so out of date.

Feel free to fix this one occurrence or migrate my work - Either or is fine dont feel pressured into doing that as i understand its quiet a bit of work.

sean-brydon avatar Apr 28 '23 07:04 sean-brydon

Hi @sean-brydon, I saw you requested a review on your pull. Do you think it will get reviewed or shall I merge your changes across?

Hallidayo avatar May 07 '23 17:05 Hallidayo

Hi @sean-brydon, I saw you requested a review on your pull. Do you think it will get reviewed or shall I merge your changes across?

Oh hey - if you could merge my changes across that would be great! - Lost track of the PR with other tasks

Thanks @Hallidayo 🙏

sean-brydon avatar May 15 '23 10:05 sean-brydon