cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

perf: fix multiple versions of `emotion/react` loaded warning

Open G3root opened this issue 1 year ago • 3 comments

What does this PR do?

upgrades react-timezone-select to prevent loading multiple versions of @emotion/react. ref: https://github.com/ndom91/react-timezone-select/issues/60#issuecomment-1484759792

initial warning:

Screenshot 2023-04-27 21:36:40

Type of change

  • Bug fix (non-breaking change which fixes an issue)

G3root avatar Apr 27 '23 16:04 G3root

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 7:35pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2023 7:35pm

vercel[bot] avatar Apr 27 '23 16:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 191.31 KB 341.74 KB 97.64% (🟡 +0.16%)
/availability/[schedule] 315.35 KB 465.78 KB 133.08% (🟢 -9.09%)
/event-types/[type] 466.91 KB 617.33 KB 176.38% (🟡 +0.20%)
/getting-started/[[...step]] 381.39 KB 531.81 KB 151.95% (🟢 -9.10%)
/settings/admin/users/[id]/edit 316.52 KB 466.94 KB 133.41% (🟢 -9.09%)
/settings/admin/users/add 316.24 KB 466.66 KB 133.33% (🟢 -9.09%)
/settings/my-account/general 310.33 KB 460.76 KB 131.64% (🟢 -9.09%)
/settings/teams/[id]/members 341.76 KB 492.18 KB 140.62% (🟢 -9.09%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 27 '23 16:04 github-actions[bot]

Current Playwright Test Results Summary

✅ 107 Passing - ❌ 3 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/27/2023 07:46:12pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 915440cf741ec121301329608db865dbe9d585c7

Started: 04/27/2023 07:36:59pm UTC

❌ Failures

📄   packages/embeds/embed-core/playwright/tests/action-based.test.ts • 2 Failures

Top 1 Common Error Messages

Expected to provide an iframe, got null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
Error: Expected to provide an iframe, got null
Expected to provide an iframe, got null
8.72% (15) 15 / 172 runs
failed over last 7 days
16.28% (28) 28 / 172 runs
flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme
Retry 2Retry 1Initial Attempt
Error: Expected to provide an iframe, got null
Expected to provide an iframe, got null
8.72% (15) 15 / 172 runs
failed over last 7 days
1.74% (3) 3 / 172 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
Error: Embed iframe not found
Embed iframe not found
8.72% (15) 15 / 172 runs
failed over last 7 days
2.33% (4) 4 / 172 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Apr 27 '23 16:04 deploysentinel[bot]

FYI this PR is breaking website. https://github.com/calcom/website/issues/487

zomars avatar May 04 '23 11:05 zomars