cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: remove duplicate value i18n

Open Udit-takkar opened this issue 2 years ago • 4 comments
trafficstars

What does this PR do?

Fixes https://github.com/calcom/cal.com/issues/8546

I just used this simple script to find all duplicate values


const valueSet = new Set();

for (const key in common) {
    if (valueSet.has(common[key])) {
      console.log(`Duplicate value found in: ${key}`);
    } else {
      valueSet.add(common[key]);
    }
}

Environment: Staging(main branch) / Production

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

Udit-takkar avatar Apr 27 '23 12:04 Udit-takkar

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 11:12pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 11:12pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 11:12pm
website ❌ Failed (Inspect) Jun 7, 2023 11:12pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Jun 7, 2023 11:12pm

vercel[bot] avatar Apr 27 '23 12:04 vercel[bot]

NEXT: remove all these keys from other languages JSON file

Udit-takkar avatar Apr 27 '23 12:04 Udit-takkar

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 27 '23 12:04 github-actions[bot]

Current Playwright Test Results Summary

✅ 107 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/07/2023 11:15:11pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 92395350250ea6dfa836c25f184f1093e68d0804

Started: 06/07/2023 11:13:06pm UTC

⚠️ Flakes

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
6.41% (15) 15 / 234 runs
failed over last 7 days
93.59% (219) 219 / 234 runs
flaked over last 7 days

📄   apps/web/playwright/auth/delete-account.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Can delete user account
Retry 1Initial Attempt
0.74% (3) 3 / 406 runs
failed over last 7 days
4.93% (20) 20 / 406 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Apr 27 '23 13:04 deploysentinel[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 17 '23 00:05 github-actions[bot]

@Udit-takkar can you reveisit this one? or is it too many conflicts?

PeerRich avatar Jun 06 '23 10:06 PeerRich

@PeerRich fixing this PR

Udit-takkar avatar Jun 06 '23 10:06 Udit-takkar