Fix form inputs height to 36px

[ExplorerAadi]

What does this PR do?

It makes the height consistent i.e. 36px for form inputs and I have also attached a loom video to show to verify. It also fixes a small bug where the select bg when disabled is creating issue in dark mode. Check the input type field of the booking question form in the screenshot I attached and then check that field in the loom video. I simply added the same class for disabled select input that was being used for text input.

Fixes #8511 and #8512

Loom Video: https://www.loom.com/share/7b5de63965dd4568919c4bf3eb467962

Screenshot of the other issue:

Environment: Staging(main branch) / Production

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• Go to any event and then the advanced menu and open the form to edit a booking question then inspect the fields.
• Go to event setup menu and then try to inspect the location field before selecting a value and then after.

Checklist

• I haven't added tests that prove my fix is effective or that my feature works

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 2, 2023 9:32pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 2, 2023 9:32pm

[vercel[bot]]

@ExplorerAadi is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/apps/[slug]/[...pages]	456.19 KB	606.65 KB	173.33% (🟡 +0.18%)
/auth/setup	174.61 KB	325.08 KB	92.88% (🟡 +0.16%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

[ExplorerAadi]

@Udit-takkar Hey buddy, Did you test after removing those values? min-h-8.5 was to adjust heights of input addOns because after adding their 1px border width, their overall container height would be 36px and match the inputs.

I have also added a loom with all the changes working properly. And after replacing the min-h-8.5, the addOns in the input look slightly off as you can see in this screenshot.

[ExplorerAadi]

@Udit-takkar I have updated the PR with my earlier fix for input addOns. Thanks a lot for the review and catching a redundant custom tailwind class.

[Udit-takkar]

@ExplorerAadi you are right maybe we should use h-9 instead of min-h-8.5 in the AddOn component.

[ExplorerAadi]

@Udit-takkar Yes, that works too and we won't need a custom class. I have updated with the changes, thanks a lot for you input.