cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Techdebt/dynamic load editor

Open emrysal opened this issue 2 years ago • 4 comments
trafficstars

What does this PR do?

Fixes # (issue)

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • [ ] Test A
  • [ ] Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

emrysal avatar Apr 24 '23 00:04 emrysal

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 0:44am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 0:44am

vercel[bot] avatar Apr 24 '23 00:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 164.15 KB 313.67 KB 89.62% (🟢 -0.16%)
/event-types 357.66 KB 507.18 KB 144.91% (🟢 -20.62%)
/event-types/[type] 393.63 KB 543.15 KB 155.19% (🟢 -20.74%)
/getting-started/[[...step]] 341.79 KB 491.32 KB 140.38% (🟢 -20.83%)
/settings/my-account/profile 277.17 KB 426.7 KB 121.91% (🟢 -20.78%)
/settings/teams/[id]/profile 271.89 KB 421.42 KB 120.40% (🟢 -20.78%)
/workflows/[workflow] 299.81 KB 449.34 KB 128.38% (🟢 -20.74%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 24 '23 00:04 github-actions[bot]

Current Playwright Test Results Summary

✅ 69 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/24/2023 12:47:41am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a80dab3ab494e54052db09baf67dd02339f7ecb5

Started: 04/24/2023 12:41:52am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 1Initial Attempt
0% (0) 0 / 232 runs
failed over last 7 days
7.33% (17) 17 / 232 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Apr 24 '23 00:04 deploysentinel[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 09 '23 00:05 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar May 17 '23 00:05 github-actions[bot]