cal.com
cal.com copied to clipboard
calcom
fix: changed assign to field as typeable input
What does this PR do?
Fixes #8412
Changed assign_to field as a simple typable input.
After
So after this ChildrenEventTypeSelect file is not used anymore right? but when I tried to delete it. I noticed that it's also used in event-types/[type]/index.tsx Can I remove it from there also? Or is there any other use for it?
Checklist
- I haven't added tests that prove my fix is effective or that my feature works
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 3, 2023 11:20am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@joe-shajan is attempting to deploy a commit to the cal Team on Vercel.
A member of the Team first needs to authorize it.
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
e2e test is failing is it because I changed the select input to normal typable input? @PeerRich
I think what @PeerRich meant here was to enable search within the select. What I see is it has become just a text field now.
Really? Sorry, my bad. Will change it then. Do we have that component? @hariombalhara
Select supports it already. I think it's disabled there not sure why
Ok thanks, will check that out.
Hi, @hariombalhara searchable for select was set to false. So I removed that line because the select compnent is searchable by default.
https://user-images.githubusercontent.com/69904519/235213736-0a41db5c-041f-4670-bb00-da89a54ef5b3.mp4
@joe-shajan just create a new branch and raise a new PR with packages/features/eventtypes/components/ChildrenEventTypeSelect.tsx changes
@joe-shajan just create a new branch and raise a new PR with packages/features/eventtypes/components/ChildrenEventTypeSelect.tsx changes
Sure will do that 👍