cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Enabling workflows for managed events

Open leog opened this issue 2 years ago • 6 comments

What does this PR do?

Enabling workflows for managed event types

Environment: Staging(main branch) / Production

Fixes: #8866

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  1. Create managed event type
  2. Go to edit created managed event type
  3. Go to Workflows tab
  4. Create a Workflow assigning the managed event type

leog avatar Apr 21 '23 13:04 leog

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 1:39pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 1:39pm

vercel[bot] avatar Apr 21 '23 13:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 456.23 KB 607.06 KB 173.45% (🟢 -0.17%)
/auth/setup 174.24 KB 325.07 KB 92.88% (🟢 -0.16%)
/event-types/[type] 477.39 KB 628.23 KB 179.49% (🟢 -0.15%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 21 '23 14:04 github-actions[bot]

Current Playwright Test Results Summary

✅ 112 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/15/2023 01:55:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7bba559d2e08c5b789596d979fd52a4b6709bb49

Started: 05/15/2023 01:43:44pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 2Retry 1Initial Attempt
4.94% (16) 16 / 324 runs
failed over last 7 days
29.32% (95) 95 / 324 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 330 runs
failed over last 7 days
68.48% (226) 226 / 330 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
4.97% (8) 8 / 161 runs
failed over last 7 days
5.59% (9) 9 / 161 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.test.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
10.49% (17) 17 / 162 runs
failed over last 7 days
53.70% (87) 87 / 162 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1Initial Attempt
0.50% (1) 1 / 201 run
failed over last 7 days
12.44% (25) 25 / 201 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Apr 21 '23 14:04 deploysentinel[bot]

One other small thing you can see in the loom: It shows the wrong number of active event types when disabling or enabling a managed event type in the dropdown

Left it to just reflect selected event type, no children taken into account

leog avatar May 05 '23 15:05 leog

the managed event type of an admin user never shows as checked in the dropdown of a personal workflow, even when it is set as active:

https://www.loom.com/share/18f57610d3684677b9b1bda516beeba3

CarinaWolli avatar May 08 '23 08:05 CarinaWolli

the managed event type of an admin user never shows as checked in the dropdown of a personal workflow, even when it is set as active:

Thanks @CarinaWolli for bringing this to my attention. It should be fixed now. PTAL.

leog avatar May 11 '23 14:05 leog