cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1568] Language on Team Invite not Updating

Open shirazdole opened this issue 1 year ago β€’ 16 comments

Updated my language from English to French. The first team invite email was sent in French, the second team invite email was sent in English. I double checked, and the language in settings was still French.

[email protected] for the first one, [email protected] for the second one. Both inviting to Cal.com team

From SyncLinear.com | CAL-1568

shirazdole avatar Apr 21 '23 09:04 shirazdole

@shirazdole would like to help! can you assign me this

ameeetgaikwad avatar Apr 29 '23 14:04 ameeetgaikwad

@shirazdole hey i would like to work on this issue, can you assign me please.

rupak21 avatar Apr 29 '23 15:04 rupak21

@shirazdole I'm facing this issue when I run yarn dx : Can you help me with this? image

ameeetgaikwad avatar Apr 30 '23 09:04 ameeetgaikwad

@ameeetgaikwad run yarn dx with sudo -->(sudo yarn dx)

tony83033 avatar Apr 30 '23 17:04 tony83033

I am trying to reproduce the issue, these are the steps that I followed:

  1. Created the event with the standard values.
  2. In advanced, I have added my name and email in the guest section.
  3. After that chose the date from the list of provided dates and confirmed the meeting.

I have been given that Your booking has been confirmed and was given the meeting details. I could see a confirmation that the emails were sent to the organizer and the guests. However, I didn't receive any email confirmation for the meeting event.

Is there any way I have to setup my email to the system before sending mails. Any help in this regard is much helpful. Thank you in advance for the help.

SridharPerepu avatar Apr 30 '23 21:04 SridharPerepu

@shirazdole

Steps taken:

  1. Changed language from English to French in jayantamadhav account
  2. Created a team and added jayantamadhav-1 & jayantamadhav-2 which triggers the invites.

I can confirm that I received both of the email invites in French.

Idk if this solves the issue you raised. If you could provide a little more context or information, things would be clearer.

jayantamadhav avatar May 20 '23 01:05 jayantamadhav

@PeerRich

lets assume user1 has set French & user2 has set English. When user1 creates a team and invites user2, user2 would receive the mail in French (I can confirm because I noticed this while testing and mentioned above).

Shouldn't the email template language respect the receiver's language and not the sender's?

jayantamadhav avatar May 20 '23 02:05 jayantamadhav

@shirazdole I'm facing this issue when I run yarn dx : Can you help me with this? image

I faced the same issue, found a work around copy the .env file's content in prisma's .env it will work

Ashish0253 avatar May 23 '23 19:05 Ashish0253

@shirazdole @PeerRich i reproduced this thing in prod this was the flow .... Screenshot 2023-05-25 at 11 17 07 PM i'm guessing you want both emails to be in french because the organizers language is french ? very unsure about the solution πŸ‘‡πŸΌ

saurabbot avatar May 25 '23 17:05 saurabbot

@PeerRich why are we sending team invite email in organiser's language ? i think we should send emails in english

Udit-takkar avatar May 25 '23 20:05 Udit-takkar

I think it should be

  1. If the user has a cal.com account associated with their email when booking an event, then it sends in their language they have already selected

  2. If the user does not have a cal.com account, then it should be sent in the organizer's language

I.e. I book with @baileypumfleet with my Shiraz Dole account. @baileypumfleet as the organizer has his language as Jamaican and mines English. The team invite email should be in English, but let's say I don't have an account yet for example, then the team invite email should be in Jamaican

Damn this is Jamaican me craaaazy

shirazdole avatar May 26 '23 09:05 shirazdole

cc @Jaibles

shirazdole avatar May 26 '23 09:05 shirazdole

Are we talking about team invites here or bookings confirmations? The original issue is talking about admins & team invites and the comments are about organisers and bookings/events.

ciaranha avatar May 26 '23 11:05 ciaranha

Original was team invite correct...

shirazdole avatar May 26 '23 11:05 shirazdole

In that case having language settings for a team would solve the issue for invites. We've had this in designs since last year but it was missed.

CleanShot 2023-05-26 at 13 02 33@2x

ciaranha avatar May 26 '23 12:05 ciaranha

@sean-brydon is this something you can look into since you are working on improving team invites?

PeerRich avatar May 26 '23 12:05 PeerRich

@shirazdole I'm facing this issue when I run yarn dx : Can you help me with this? image

I faced the same issue, found a work around copy the .env file's content in prisma's .env it will work

you can paste DATABASE_URL link directly to schema.prisma file it will work smoothly basically it cannot find the database u are linking to so

parthiv011 avatar Sep 19 '23 09:09 parthiv011