cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: add focus state for select component

Open G3root opened this issue 2 years ago • 6 comments

What does this PR do?

Fixes #8195

  • [x] add focus ring for select component Screenshot 2023-04-13 22:49:40

  • [x] fix border issue in phone input Screenshot 2023-04-13 at 22-48-48 Confirm your multi with Team Pro Example 2 Cal com

Type of change

  • Bug fix (non-breaking change which fixes an issue)

G3root avatar Apr 13 '23 17:04 G3root

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 7:24am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 7:24am

vercel[bot] avatar Apr 13 '23 17:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 13 '23 17:04 github-actions[bot]

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/27/2023 07:37:36am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: b705fd958d508e76d3494fa343c3859f18f3e195

Started: 04/27/2023 07:28:10am UTC

⚠️ Flakes

📄   apps/web/playwright/manage-booking-questions.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Manage Booking Questions For Team EventType -- old-booker Do a booking with a user added question and verify a few thing in b/w
Retry 1Initial Attempt
3.80% (3) 3 / 79 runs
failed over last 7 days
18.99% (15) 15 / 79 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Apr 13 '23 17:04 deploysentinel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 94.17 KB 325.17 KB 92.90% (🟢 -5.04%)
/[user]/[type]/embed 94.2 KB 325.2 KB 92.91% (🟢 -5.04%)
/[user]/book 188.17 KB 419.17 KB 119.76% (🟢 -0.14%)
/auth/setup 82.08 KB 313.08 KB 89.45% (🟡 +0.16%)
/d/[link]/[slug] 93.81 KB 324.81 KB 92.80% (🟢 -5.04%)
/d/[link]/[slug]/embed 93.84 KB 324.84 KB 92.81% (🟢 -5.04%)
/d/[link]/book 187.82 KB 418.82 KB 119.66% (🟢 -0.14%)
/team/[slug]/[type] 93.81 KB 324.81 KB 92.80% (🟢 -5.04%)
/team/[slug]/[type]/embed 93.84 KB 324.84 KB 92.81% (🟢 -5.04%)
/team/[slug]/book 187.82 KB 418.82 KB 119.66% (🟢 -0.14%)
/video/[uid] 43.6 KB 274.6 KB 78.46% (🟢 -3.29%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 13 '23 19:04 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 389.07 KB 620.35 KB 177.24% (🟢 -0.17%)
/auth/setup 81.57 KB 312.86 KB 89.39% (🟢 -0.17%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 18 '23 00:04 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar May 12 '23 00:05 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar May 19 '23 00:05 github-actions[bot]