fix: Change Detroit to New York as a default for EST time zone

[gitstart-calcom]

trafficstars

Fixes #8119

Loom video: https://www.loom.com/share/441a4a207e5845c1bf9a786b83334dd9

[linear[bot]]

CAL-1419 Change Detroit to New York as a default for EST time zone

Detroit as default for EST is weird.

• [ ] Instead do America/New York
• [ ] Also: lets replace "_" with " ":

Los_Angeles => Los Angeles

Created via Threads. See full discussion: https://threads.com/34461922510

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 26, 2023 11:59am
web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 26, 2023 11:59am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
api	⬜️ Ignored (Inspect)	Visit Preview		May 26, 2023 11:59am
ui	⬜️ Ignored (Inspect)	Visit Preview		May 26, 2023 11:59am

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/26/2023 12:19:15pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: d27d58540879c3803a6e46f0c5e89eaef26da4fd

Started: 05/26/2023 12:08:22pm UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Managed Event Types tests Can create managed event type Retry 1 • Initial Attempt	1.99% (8) 8 / 403 runs failed over last 7 days	21.84% (88) 88 / 403 runs flaked over last 7 days

---

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted Retry 1 • Initial Attempt	0% (0) 0 / 427 runs failed over last 7 days	86.65% (370) 370 / 427 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	3.80% (3) 3 / 79 runs failed over last 7 days	49.37% (39) 39 / 79 runs flaked over last 7 days

---

View Detailed Build Results

---

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[github-actions[bot]]

This PR is being marked as stale due to inactivity.

[github-actions[bot]]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

[gitstart-calcom]

Blocking to go with the patch approach instead. My rationale is that this is too hacky and unsustainable in the long term.

We are working on the patch approach and we have made some progress. We will share an update soon.

[gitstart-calcom]

Hi @zomars @PeerRich, it seems like the patch package might not solve the issue.

Using the path-package lib to make the changes directly on the node_modules file, we faced some problems because the react-timezone-select lib uses a lib called spacetime to make the integration with the timezones, and these timezones should have the keys with "_" (like "America/Sao_Paulo). So these changes can be done only on the frontend (like we did as the initial idea), in this case, we will change the timezone names only visually.

As an example here, we need to pass the timezone as "America/Sao_Paulo", if we change this we have the following error:

The same goes for "America/Detroit".

[zomars]

Hi @zomars @PeerRich, it seems like the patch package might not solve the issue.

Using the path-package lib to make the changes directly on the node_modules file, we faced some problems because the react-timezone-select lib uses a lib called spacetime to make the integration with the timezones, and these timezones should have the keys with "_" (like "America/Sao_Paulo). So these changes can be done only on the frontend (like we did as the initial idea), in this case, we will change the timezone names only visually.

As an example here, we need to pass the timezone as "America/Sao_Paulo", if we change this we have the following error:

The same goes for "America/Detroit".

Let's revisit the patch solution later on. I think we're good for now.