[CAL-1095] Embed modal (floating pop up button) - UI/layout/spacing issues

[gitstart-calcom]

trafficstars

Fixes #7156

Demo

https://www.loom.com/share/6f52f4e1fab640e39dd0ec5717ace0d0

[linear[bot]]

CAL-1095 Embed modal (floating pop up button) - UI/layout/spacing issues

Currently

CleanShot 2023-02-16 at 19.21.112x.png

Should be

CleanShot 2023-02-16 at 19.26.302x.png

View in Figma

Note: No need to touch the preview - just the modal and left panel UI.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 2, 2023 6:41pm
web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 2, 2023 6:41pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
ui	⬜️ Ignored (Inspect)	Visit Preview		May 2, 2023 6:41pm

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/apps/[slug]/[...pages]	455.56 KB	606.02 KB	173.15% (🟢 -0.32%)
/auth/setup	174.04 KB	324.49 KB	92.71% (🟢 -0.16%)
/event-types	415.89 KB	566.35 KB	161.81% (🟡 +0.18%)
/event-types/[type]	450.67 KB	601.13 KB	171.75% (🟢 -0.16%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 112 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/02/2023 06:48:22pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7da271f4f45b09d0663b35eb9d8c9345e0a3076b

Started: 05/02/2023 06:38:11pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type Retry 1 • Initial Attempt	3.21% (6) 6 / 187 runs failed over last 7 days	21.39% (40) 40 / 187 runs flaked over last 7 days

---

📄   apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
pro user -- new-booker Can cancel the recently created booking and rebook the same timeslot Retry 1 • Initial Attempt	1.04% (2) 2 / 193 runs failed over last 7 days	2.59% (5) 5 / 193 runs flaked over last 7 days

---

📄   apps/web/playwright/app-store.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
App Store - Authed Browse apple-calendar and try to install Retry 1 • Initial Attempt	0.99% (2) 2 / 202 runs failed over last 7 days	42.57% (86) 86 / 202 runs flaked over last 7 days

---

📄   packages/embeds/embed-core/playwright/tests/action-based.test.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	12.69% (17) 17 / 134 runs failed over last 7 days	44.03% (59) 59 / 134 runs flaked over last 7 days

---

View Detailed Build Results

---

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/auth/setup	80.22 KB	313.01 KB	89.43% (🟢 -0.19%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

[PeerRich]

we should also extract all strings into en/common.json

[hariombalhara]

Too much spacing above Theme Selector in Inline and Element Click

[hariombalhara]

@CarinaWolli I guess it just needs your review to be merged.