cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

feat: Add Zoho Bigin app to appstore

Open ShaneMaglangit opened this issue 2 years ago • 14 comments

What does this PR do?

Creates a new Zoho Bigin app under the App Store for direct integration. New bookings automatically creates a corresponding "Contact" and "Event" records on the Zoho Bigin platform.

Fixes #5450

https://www.loom.com/share/cb2dcb487753468f87844d57f137eb8b

Environment: Staging(main branch)

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Install Zoho Bigin from the playstore.
  • Book a new meeting: New Contacts and Activities > Event should be added on Bigin.
  • Deleting a meeting from Cal.com should also reflect on the Event page.

/claim #5450

ShaneMaglangit avatar Apr 09 '23 07:04 ShaneMaglangit

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 2:27pm

vercel[bot] avatar Apr 09 '23 07:04 vercel[bot]

@ShaneMaglangit is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 09 '23 07:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 09 '23 07:04 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 183.52 KB 416.64 KB 119.04% (🟡 +0.20%)
/auth/setup 79.98 KB 313.09 KB 89.46% (🟢 -0.19%)
/d/[link]/book 183.17 KB 416.29 KB 118.94% (🟡 +0.20%)
/team/[slug]/book 183.17 KB 416.29 KB 118.94% (🟡 +0.20%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 09 '23 09:04 github-actions[bot]

hey @ShaneMaglangit we will test this this week!

PeerRich avatar Apr 19 '23 14:04 PeerRich

I have started testing it. Facing some issues locally, debugging them and will get back.

I have fixed a few things that are in terms of calendar app creation in general. As there is no calendar app creation app-store template, this is needed. Once we create a calendar template, those changes won't be needed.

hariombalhara avatar Apr 20 '23 13:04 hariombalhara

@hariombalhara pushed some changes, particularly with the expiration date management. Would appreciate if you can have another look.

ShaneMaglangit avatar Apr 22 '23 15:04 ShaneMaglangit

I am still unable to make it work.

image

I have given appropriate permissions Screenshot 2023-04-24 at 11 33 52 AM

It might be some issue with my zoho test account maybe ? Can you do an uninstall of the app and do a fresh install and share the loom that it's working for you.

Also, if you would like you can book me here and we can sort out this issue together https://cal.com/hariom/30min

hariombalhara avatar Apr 24 '23 06:04 hariombalhara

@hariombalhara can you do a quick check if you have Multi-DC thingy enabled in Zoho?

image

just noticed that you're from India, so you might be generating a zoho.in token.

ShaneMaglangit avatar Apr 25 '23 09:04 ShaneMaglangit

Screenshot 2023-04-25 at 2 53 06 PM Yeah it's enabled.

hariombalhara avatar Apr 25 '23 09:04 hariombalhara

@hariombalhara I might have found the issue. The refresh_token API does not return itself. Yet, the previous code was not storing the existing refresh_token.

You would need to uninstall/reinstall the app. Start with a fresh database (or at least without the old credentials). To be sure, try creating an event again after an hour (default expiration) to make sure the refresh stuffs work properly.

Please let me know if this still doesn't resolve this so I can book a meeting with you.

ShaneMaglangit avatar Apr 25 '23 14:04 ShaneMaglangit

I have already tried disconnecting and reconnecting the app, and even tried deleting the credentials directly from DB. I would give it a go one more time. I would like you to still book cal.com/hariom to sort it out. If it works for me then we can skip the meeting.

hariombalhara avatar Apr 26 '23 11:04 hariombalhara

I have already tried disconnecting and reconnecting the app, and even tried deleting the credentials directly from DB. I would give it a go one more time. I would like you to still book cal.com/hariom to sort it out. If it works for me then we can skip the meeting.

@hariombalhara booked a meeting under the name Shane. This might be silly but if you are yet to test this one again, please make sure you pulled the most recent commit.

ShaneMaglangit avatar Apr 26 '23 13:04 ShaneMaglangit

@hariombalhara pushed some stuffs for the solution we found earlier.

Note: we might have to fix the Zoho CRM app. A large part of this PR was derived off that and its likely to have the same bug with the api domain.

ShaneMaglangit avatar Apr 27 '23 11:04 ShaneMaglangit

@ShaneMaglangit Looks like I am not able to connect the application with other accounts. I created the Server Based App in Account-1(A Cal.com account) then I am trying to install Zoho Bigin App with my personal account(Account-2). It always gives this error. Screenshot 2023-05-24 at 9 30 48 PM

hariombalhara avatar May 24 '23 16:05 hariombalhara