cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[App Store] Zoho Calendar

Open murtajaziad opened this issue 1 year ago • 10 comments

What does this PR do?

An app to integrate Zoho Calendar and Cal.com using the official Zoho Calendar API.

Fixes #5451

Environment: Staging(main branch)

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

No automated tests are set up for this. You can manually test the integration by following these steps:

  1. Link your Zoho account with your Cal.com account.
  2. Set your default calendar for creating the events to your Zoho Calendar.
  3. Book an event to try the integration.

Checklist

  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

/claim #5451

murtajaziad avatar Apr 08 '23 01:04 murtajaziad

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api 🔄 Building (Inspect) Jul 18, 2023 6:34pm
cal 🔄 Building (Inspect) Jul 18, 2023 6:34pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 6:34pm
web-staging 🔄 Building (Inspect) Jul 18, 2023 6:34pm

vercel[bot] avatar Apr 08 '23 01:04 vercel[bot]

@murtajaziad is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 08 '23 01:04 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 08 '23 01:04 github-actions[bot]

@murtajaziad Thanks for the PR !! I am wondering if https://github.com/calcom/cal.com/pull/7182 added similar functionality already or not. Also, if it didn't would it make sense to add the functionality into that existing app.

hariombalhara avatar Apr 08 '23 06:04 hariombalhara

@murtajaziad Thanks for the PR !! I am wondering if #7182 added similar functionality already or not. Also, if it didn't would it make sense to add the functionality into that existing app.

HI @hariombalhara, I have just checked #7182 and it doesn't include any Zoho Calendar functionality, it uses the events/meetings module that's provided by the CRM API. Also, Zoho Calendar and Zoho CRM are two different products that apparently don't overlap.

murtajaziad avatar Apr 08 '23 11:04 murtajaziad

@PeerRich can you confirm if we want to do it in a separate app?

hariombalhara avatar Apr 08 '23 11:04 hariombalhara

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 80.65 KB 313.77 KB 89.65% (🟡 +0.19%)
/event-types/[type] 382.03 KB 615.16 KB 175.76% (🟡 +0.18%)
/settings/admin/apps 164.21 KB 397.33 KB 113.52% (🟡 +0.14%)
/settings/admin/apps/[category] 164.2 KB 397.32 KB 113.52% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 08 '23 12:04 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 80.65 KB 313.77 KB 89.65% (🟡 +0.19%)
/event-types/[type] 382.03 KB 615.16 KB 175.76% (🟡 +0.17%)
/settings/admin/apps 164.21 KB 397.34 KB 113.52% (🟡 +0.15%)
/settings/admin/apps/[category] 164.2 KB 397.32 KB 113.52% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 08 '23 13:04 github-actions[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/auth/setup 80.65 KB 313.77 KB 89.65% (🟡 +0.19%)
/event-types/[type] 382.03 KB 615.16 KB 175.76% (🟡 +0.17%)
/settings/admin/apps 164.21 KB 397.33 KB 113.52% (🟡 +0.14%)
/settings/admin/apps/[category] 164.2 KB 397.32 KB 113.52% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Apr 08 '23 13:04 github-actions[bot]

@murtajaziad Please add a loom showing the functionality of the app and also step by step details on how I can obtain client_id and client_secret

hariombalhara avatar Apr 19 '23 13:04 hariombalhara

Screenshot 2023-05-10 at 11 54 08 AM I see `undefined` here. Also, I think for the same reason I see this error while booking. Screenshot 2023-05-10 at 12 06 05 PM

For debugging I printed zoho calendar object and I didn't see emai in there Screenshot 2023-05-10 at 12 09 22 PM

hariombalhara avatar May 10 '23 06:05 hariombalhara

Thank you for following the naming conventions! 🙏

github-actions[bot] avatar Jun 22 '23 22:06 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

keithwillcode avatar Jul 25 '23 15:07 keithwillcode