cal.com
cal.com copied to clipboard
calcom
fix: /routing-form/single - Don't clear edits when moving from one tab to the other
Fixes #6633
https://www.loom.com/share/a40641c60111483986b629450d9b8176
CAL-865 /routing-form/single - Don't clear edits when moving from one tab to the other
The problem: Changing the tab clears the form
921b3149-6896-44a8-ac8b-d890679b9bfa
The solution:
Do it like we do in event types. I should be able to move from one tab to the other and not lose my changes.
![linear[bot] avatar](https://avatars.githubusercontent.com/in/20150?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 19, 2024 3:22pm |
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 19, 2024 3:22pm |
| cal-staging | 🔄 Building (Inspect) | Mar 19, 2024 3:22pm | ||
| ui | ❌ Failed (Inspect) | Mar 19, 2024 3:22pm | ||
| web | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 19, 2024 3:22pm |
2 Ignored Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| dev | ⬜️ Ignored (Inspect) | Mar 19, 2024 3:22pm | ||
| web-staging | ⬜️ Ignored (Inspect) | Mar 19, 2024 3:22pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Current Playwright Test Results Summary
✅ 127 Passing - ⚠️ 4 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 07/09/2023 04:59:57pm UTC)
Run Details
Running Workflow PR Update on Github Actions
Commit: 765c39418f7c751d1799a142502d45fd75da9e9e
Started: 07/09/2023 04:57:23pm UTC
⚠️ Flakes
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests -- new-booker should be able to reschedule
Retry 1 • Initial Attempt |
15.79% (30)30 / 190 runsfailed over last 7 days |
83.16% (158)158 / 190 runsflaked over last 7 days |
|
Popup Tests -- old-booker should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
0% (0)0 / 189 runsfailed over last 7 days |
15.34% (29)29 / 189 runsflaked over last 7 days |
|
Popup Tests -- old-booker should be able to reschedule
Retry 1 • Initial Attempt |
3.19% (6)6 / 188 runsfailed over last 7 days |
75.53% (142)142 / 188 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1 • Initial Attempt |
0.94% (2)2 / 213 runsfailed over last 7 days |
41.31% (88)88 / 213 runsflaked over last 7 days |
![deploysentinel[bot] avatar](https://avatars.githubusercontent.com/in/210057?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @hariombalhara, we have implemented the requested changes. Can you please take a look?
@gitstart I don't see a self review in the PR. Please go through the PR and add comments where the code might not be obvious.
Hi @CarinaWolli, we made the requested changes, please take a look 😄