cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1296] MultiSelectCheckboxes should merge with Select

Open sean-brydon opened this issue 2 years ago • 6 comments

MultiSelectCheckboxes should merge with Select and should be controlled via variant prop. There is no real reason for us to make these two seperate things

From SyncLinear.com | CAL-1296

sean-brydon avatar Mar 20 '23 13:03 sean-brydon

assigning you, ok?

PeerRich avatar Mar 20 '23 23:03 PeerRich

If this issue is still open. Can you assign this to me? I am very interested in contributing to cal.com and exploring the code source from the day I found out about this.

Devansh-365 avatar Mar 29 '23 03:03 Devansh-365

Hey @Devansh-365 feel free! Sorry i missed this in my inbox - Gimme a shout if you have any questions.

We have a few selects that need cleaned up but the one we want to merge with is at

packages/ui/components/form/select/Select.tsx

sean-brydon avatar Apr 12 '23 08:04 sean-brydon

Hey @sean-brydon & @PeerRich , I was working on this refactor but this is only implemented in workflows section and I cannot test it because accessing workflows need some license. Could you please help me out with it? image

ExplorerAadi avatar Apr 28 '23 19:04 ExplorerAadi

Hey @sean-brydon & @PeerRich , I was working on this refactor but this is only implemented in workflows section and I cannot test it because accessing workflows need some license. Could you please help me out with it? image

Hey bud can you DM me on our slack or hit me up on twitter DMs . I'll get this sorted for you

sean-brydon avatar Apr 29 '23 10:04 sean-brydon

@sean-brydon Thanks for the help, I have raised a PR with the refactor: https://github.com/calcom/cal.com/pull/8623

ExplorerAadi avatar May 04 '23 10:05 ExplorerAadi

@keithwillcode is the issue still open?

dhruvgupta0503 avatar Nov 29 '23 14:11 dhruvgupta0503