cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1477] Rounding, frames and radio buttons of the booking forms not consistent

Open RainerZufall9393 opened this issue 2 years ago • 7 comments

  1. The rounding of the frame for the phone number is different from the other fields.
  2. For the "Name" field, the frame is much thinner than for the other input fields and is displayed only in the branding color. For the other fields there is an additional black frame next to the branding color.
  3. The radio buttons do not adopt the branding color, they just stay black.

https://user-images.githubusercontent.com/126205884/222868015-51c26cc0-d31a-41eb-b6b1-d51c9e18eb77.mov

CAL-1477

RainerZufall9393 avatar Mar 04 '23 01:03 RainerZufall9393

Nice spots! Will work on a fix for this!

sean-brydon avatar Mar 05 '23 07:03 sean-brydon

Will fix within our new token update - makes this a lot easier than fixing twice! Soon!

sean-brydon avatar Mar 09 '23 15:03 sean-brydon

@gitstart-calcom here is the figma: https://www.figma.com/file/9MOufQNLtdkpnDucmNX10R/%E2%9D%96-Cal-DS?node-id=309-44674

PeerRich avatar Apr 12 '23 12:04 PeerRich

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/calcom/1/tickets/CALCOM-7508

gitstart-app[bot] avatar Apr 12 '23 12:04 gitstart-app[bot]

Hey @PeerRich @sean-brydon , I believe that we should upgrade the "react-phone-numer-input" lib to "react-phone-input-2", I've been tried to change the flag component style but I think that's not possible on the current lib. This is the entire component:

image Should be this:

image

What do you think?

Toledodev avatar Apr 18 '23 22:04 Toledodev

react-phone-input-2 looks good. any insights whats different? As long as the design is like its supposed to be in figma and the different package is not crazy bigger i dont mind switching cc @zomars

PeerRich avatar Apr 24 '23 15:04 PeerRich

Fine by me

zomars avatar Apr 24 '23 16:04 zomars