cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

UI/list item - One list for them all

Open sean-brydon opened this issue 2 years ago • 7 comments

Adds one list for them all.

Few pages missing as this PR was getting a bit big and others required some more work than the base component thats been created Sizzy-Galaxy Note 10 undefined 20Feb 22 09-1 Sizzy-Galaxy Note 10 undefined 20Feb 22 09 Sizzy-iPad Pro 11 undefined 20Feb 22 09 Sizzy-Macbook Pro 15 undefined 20Feb 22 09

sean-brydon avatar Feb 20 '23 22:02 sean-brydon

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 10:25PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2023 at 10:25PM (UTC)

vercel[bot] avatar Feb 20 '23 22:02 vercel[bot]

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 210.39 KB (🟢 -28 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Forty-seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 188.56 KB 398.95 KB 113.99% (🟡 +0.03%)
/apps 171.18 KB 381.58 KB 109.02% (🟡 +0.11%)
/apps/[slug] 194.81 KB 405.2 KB 115.77% (🟡 +0.11%)
/apps/[slug]/[...pages] 394.78 KB 605.17 KB 172.90% (🟢 -0.03%)
/apps/categories 156.09 KB 366.48 KB 104.71% (🟡 +0.11%)
/apps/categories/[category] 159.95 KB 370.34 KB 105.81% (🟡 +0.11%)
/apps/installed/[category] 198.54 KB 408.93 KB 116.84% (🟢 -0.07%)
/auth/setup 104.23 KB 314.63 KB 89.89% (🟡 +0.23%)
/availability 159.26 KB 369.65 KB 105.62% (🟡 +0.09%)
/availability/[schedule] 272.14 KB 482.53 KB 137.87% (🟡 +0.07%)
/availability/troubleshoot 156.78 KB 367.17 KB 104.91% (🟡 +0.10%)
/booking/[uid] 131.39 KB 341.78 KB 97.65% (🟡 +0.04%)
/bookings/[status] 266.44 KB 476.83 KB 136.24% (🟡 +0.10%)
/d/[link]/book 188.22 KB 398.61 KB 113.89% (🟡 +0.03%)
/event-types 352.1 KB 562.49 KB 160.71% (🟡 +0.11%)
/event-types/[type] 385.21 KB 595.6 KB 170.17% (🟡 +0.11%)
/getting-started/[[...step]] 331.87 KB 542.26 KB 154.93% (🟡 +0.62%)
/more 155.72 KB 366.11 KB 104.60% (🟡 +0.11%)
/settings/admin 161.14 KB 371.53 KB 106.15% (🟡 +0.11%)
/settings/admin/apps 194.28 KB 404.67 KB 115.62% (🟡 +0.17%)
/settings/admin/apps/[category] 194.26 KB 404.65 KB 115.61% (🟡 +0.18%)
/settings/admin/impersonation 161.42 KB 371.82 KB 106.23% (🟡 +0.11%)
/settings/billing 161.34 KB 371.73 KB 106.21% (🟡 +0.11%)
/settings/developer/api-keys 190.39 KB 400.78 KB 114.51% (🟡 +0.10%)
/settings/developer/webhooks 163.75 KB 374.14 KB 106.90% (🟡 +0.10%)
/settings/developer/webhooks/[id] 192.6 KB 402.99 KB 115.14% (🟡 +0.11%)
/settings/developer/webhooks/new 192.46 KB 402.85 KB 115.10% (🟡 +0.11%)
/settings/my-account/appearance 175.22 KB 385.61 KB 110.17% (🟡 +0.11%)
/settings/my-account/calendars 192.89 KB 403.29 KB 115.22% (🟢 -0.07%)
/settings/my-account/conferencing 167.17 KB 377.56 KB 107.88% (🟡 +0.15%)
/settings/my-account/general 266.42 KB 476.82 KB 136.23% (🟡 +0.11%)
/settings/my-account/profile 428.34 KB 638.74 KB 182.50% (🟡 +0.10%)
/settings/security/impersonation 163.29 KB 373.68 KB 106.77% (🟡 +0.10%)
/settings/security/password 194.55 KB 404.95 KB 115.70% (🟡 +0.11%)
/settings/security/sso 170.97 KB 381.36 KB 108.96% (🟡 +0.11%)
/settings/security/two-factor-auth 165.75 KB 376.14 KB 107.47% (🟡 +0.11%)
/settings/teams 160.89 KB 371.28 KB 106.08% (🟡 +0.11%)
/settings/teams/[id]/appearance 175.24 KB 385.63 KB 110.18% (🟡 +0.11%)
/settings/teams/[id]/billing 161.12 KB 371.51 KB 106.15% (🟡 +0.10%)
/settings/teams/[id]/members 298.05 KB 508.44 KB 145.27% (🟡 +0.11%)
/settings/teams/[id]/profile 273.53 KB 483.92 KB 138.26% (🟡 +0.11%)
/settings/teams/[id]/sso 171.07 KB 381.46 KB 108.99% (🟡 +0.11%)
/settings/teams/new 116.21 KB 326.6 KB 93.31% (🟡 +0.83%)
/team/[slug]/book 188.22 KB 398.61 KB 113.89% (🟡 +0.03%)
/teams 155.94 KB 366.33 KB 104.67% (🟡 +0.10%)
/workflows 168.83 KB 379.22 KB 108.35% (🟡 +0.11%)
/workflows/[workflow] 296.68 KB 507.08 KB 144.88% (🟡 +0.11%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Feb 20 '23 22:02 github-actions[bot]

Current Playwright Test Results Summary

✅ 52 Passing - ❌ 3 Failing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/13/2023 10:37:30pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: adae7cb1f26988dd7556ba9a09d7d098a556df25

Started: 03/13/2023 10:31:14pm UTC

❌ Failures

📄   ../tests/action-based.test.ts • 3 Failures

Top 1 Common Error Messages

Expected to provide an iframe, got null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
Error: Expected to provide an iframe, got null
Expected to provide an iframe, got null
50.36% (69) 69 / 137 runs
failed over last 7 days
0% (0) 0 / 137 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
Error: Expected to provide an iframe, got null
Expected to provide an iframe, got null
50.36% (69) 69 / 137 runs
failed over last 7 days
0% (0) 0 / 137 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
Error: Routing Form embed iframe not found
Routing Form embed iframe not found
50.36% (69) 69 / 137 runs
failed over last 7 days
0% (0) 0 / 137 runs
flaked over last 7 days

⚠️ Flakes

📄   apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Reschedule Tests Should display request reschedule send on bookings/cancelled
Retry 1Initial Attempt
0% (0) 0 / 301 runs
failed over last 7 days
1% (3) 3 / 301 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Mar 04 '23 08:03 deploysentinel[bot]

Google calendar doesn't show as expanded: Screenshot 2023-03-06 at 10 06 02

The line used to go all the way out and I think the margin around the app details got larger Screenshot 2023-03-06 at 10 06 30

CarinaWolli avatar Mar 06 '23 15:03 CarinaWolli

Google calendar doesn't show as expanded: Screenshot 2023-03-06 at 10 06 02

The line used to go all the way out and I think the margin around the app details got larger Screenshot 2023-03-06 at 10 06 30

Will fix - this is likely due to the fact the padding was on the children. Must have missed it when converting.

As for the line - correct we need some -mx on that :)

sean-brydon avatar Mar 09 '23 15:03 sean-brydon

Google calendar doesn't show as expanded: Screenshot 2023-03-06 at 10 06 02

The line used to go all the way out and I think the margin around the app details got larger Screenshot 2023-03-06 at 10 06 30

This is fixed now. Also added some other small design fixes

CarinaWolli avatar Mar 13 '23 19:03 CarinaWolli

Great work on this @sean-brydon 👏 Noticed some issues here aswell as Carina's. https://www.loom.com/share/18db10c3e1404053acefa1d2707ca620

Thanks :) I'll fix these all in the morning - should be pretty straighforward

Thanks @CarinaWolli for the help <3 getting this more up to speed while my life was a bit 100mph

sean-brydon avatar Mar 16 '23 13:03 sean-brydon

closing. stale. unmergeable

PeerRich avatar May 24 '23 16:05 PeerRich