cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1120] Add Floating Button popup tests.

Open hariombalhara opened this issue 2 years ago β€’ 4 comments

          Also, e2e were passing. It means that we don't have floatingButton popup tests. Need to add those.

Originally posted by @hariombalhara in https://github.com/calcom/cal.com/pull/7212#discussion_r1112183659

There are inline embed and 'click on an element ' embed tests already. These would be very similar to those with just one difference that the tests would execute on floating button popup

From SyncLinear.com | CAL-1120

hariombalhara avatar Feb 20 '23 16:02 hariombalhara

I might give a try to this issue (I've never written E2E tests before to be honest, but I'm interest on learning more about it)

esau-morais avatar Feb 20 '23 18:02 esau-morais

Happy to help out in any way I can :)

hariombalhara avatar Feb 20 '23 19:02 hariombalhara

I wanted to run the tests only related to embed, but it keeps failing:

yarn test-e2e --project=@calcom/embed-core

Once it starts running them, it throws the following errors:

[WebServer] Error: listen EADDRINUSE: address already in use 0.0.0.0:3000
    at Server.setupListenHandle [as _listen2] (node:net:1740:16)
    at listenInCluster (node:net:1788:12)
    at doListen (node:net:1937:7)
    at process.processTicksAndRejections (node:internal/process/task_queues:83:21) {
  code: 'EADDRINUSE',
  errno: -98,
  syscall: 'listen',
  address: '0.0.0.0',
  port: 3000
}
Error: Process from config.webServer was not able to start. Exit code: 1




  61 skipped
  1 error was not a part of any test, see above for details

To open last HTML report run:

  npx playwright show-report test-results/reports/playwright-html-report

error Command failed with exit code 1.

I tried to increase the timeout, but didn't get to make it work

esau-morais avatar Feb 21 '23 19:02 esau-morais

Follow embed-core README to run the embed tests.

hariombalhara avatar Feb 22 '23 01:02 hariombalhara

/bounty 20

PeerRich avatar Jun 05 '23 10:06 PeerRich

~~πŸ’Ž $20 bounty created by PeerRich~~ ~~πŸ™‹ If you start working on this, comment /attempt #7233 to notify everyone~~ ~~πŸ‘‰ To claim this bounty, submit a pull request that includes the text /claim #7233 somewhere in its body~~ ~~πŸ“ Before proceeding, please make sure you can receive payouts in your country~~ ~~πŸ’΅ Payment arrives in your account 2-5 days after the bounty is rewarded~~ ~~πŸ’― You keep 100% of the bounty award~~ ~~πŸ™ Thank you for contributing to calcom/cal.com!~~

Attempt Started Solution
🟒 @mitjans Jun 13, 2023 #9501

algora-pbc[bot] avatar Jun 05 '23 10:06 algora-pbc[bot]

/attempt #7233

mitjans avatar Jun 13 '23 09:06 mitjans

πŸ’‘ @mitjans submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

algora-pbc[bot] avatar Jun 14 '23 08:06 algora-pbc[bot]

πŸŽ‰πŸŽˆ @mitjans has been awarded $20! 🎈🎊

algora-pbc[bot] avatar Jun 29 '23 08:06 algora-pbc[bot]