cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Published 20 hours ago • verified publisher icon calcom

[CAL-1080] Display On bookingpage bug

Open sean-brydon opened this issue 2 years ago • 7 comments

When adding multiple locations of the same type you can only set display on booking page on one of the values. Even tho it looks like it is toggled on all of them.

Thus

cal.com/packages/app-store/locations.ts:212

doesnt display the location as its set to private.

CleanShot 2023-02-15 at 20.44.50@2x.png

From SyncLinear.com | CAL-1080

sean-brydon avatar Feb 15 '23 20:02 sean-brydon

Hi team! I've been learning new things from the codebase recently. Can I work on this issue as my first contribution?

heyanurag avatar Feb 16 '23 05:02 heyanurag

sure @heyanurag go for it!

PeerRich avatar Feb 16 '23 12:02 PeerRich

Thanks Peer! I wanted to ask, why can't I see the Add a location button in my local setup?

image

I checked the code and the button is currently behind a check validLocations.length > 0. I tried loggin the validLocations array but its empty.

image

Any help will be appreciated :)

heyanurag avatar Feb 19 '23 19:02 heyanurag

Hey @heyanurag this appears to be a recent bug which happens when you delete the location from the select box. Not 100% sure whats causing it right now as im on mobile. I believe if you create a new event type you should see add a location button

sean-brydon avatar Feb 19 '23 19:02 sean-brydon

Hi @sean-brydon even after creating a new event the issue still exists. I also created a new database but no change.

heyanurag avatar Feb 20 '23 09:02 heyanurag

hey, we have a PR fixed for this, will go live today!

PeerRich avatar Feb 20 '23 13:02 PeerRich

image Hello @PeerRich you were talking about this "Display on booking page" which is below of united states flag

Vikram125609 avatar May 02 '23 07:05 Vikram125609

Hey, @sean-brydon, I think the issue is fixed and should be closed. Pls, look at the following loom. And also there is another issue in ui with adding the same type of locations the states are saved on the component, as can be observed in the given loom. Should I open another issue for it to be explained in detail?

Loom: https://www.loom.com/share/fa15cc24c3f14722b832ec9feced2a10

JaideepGuntupalli avatar Jun 11 '23 14:06 JaideepGuntupalli

Hey, @sean-brydon, I think the issue is fixed and should be closed. Pls, look at the following loom. And also there is another issue in ui with adding the same type of locations the states are saved on the component, as can be observed in the given loom. Should I open another issue for it to be explained in detail?

Loom: https://www.loom.com/share/fa15cc24c3f14722b832ec9feced2a10

Nice find! Please raise another issue <3 I'll close this one

sean-brydon avatar Jun 11 '23 14:06 sean-brydon