cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

chore: replace <input /> with <TextField />

Open saideepesh000 opened this issue 1 year ago • 2 comments

What does this PR do?

replaces the <input /> tags of type text, number, password with <TextField />

Fixes #6742

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Chore (refactoring code, technical debt, workflow improvements)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

saideepesh000 avatar Feb 12 '23 13:02 saideepesh000

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 20, 2023 at 8:02AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2023 at 8:02AM (UTC)

vercel[bot] avatar Feb 12 '23 13:02 vercel[bot]

@saideepesh000 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 12 '23 13:02 vercel[bot]

@Udit-takkar @G3root can you two test this really extensively? we have a ton of inputs and we need to make sure 100% are working

PeerRich avatar Feb 13 '23 16:02 PeerRich

@Udit-takkar @G3root can you two test this really extensively? we have a ton of inputs and we need to make sure 100% are working

on it 👀

G3root avatar Feb 13 '23 16:02 G3root

doubling down again here: very very important that we test that every TextField works. I can already feel that some APIs wont be 100% translateable (whether its visual bugs or data bugs)

PeerRich avatar Feb 18 '23 15:02 PeerRich

i think we need to refactor input to TextField one by one, one PR for each page and thoroughly test it

closing for now, @sydwardrae can send you a gift for your work!

PeerRich avatar Mar 07 '23 12:03 PeerRich

yeah, agreed @PeerRich

saideepesh000 avatar Mar 07 '23 12:03 saideepesh000