cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

show upgrade badge and hide /team/null when team unpublished

Open PeerRich opened this issue 2 years ago • 2 comments

untested but i think this works

@zomars how can i test an unpublished team on localhost?

PeerRich avatar Feb 12 '23 13:02 PeerRich

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 7:58PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2023 at 7:58PM (UTC)

vercel[bot] avatar Feb 12 '23 13:02 vercel[bot]

untested but i think this works

@zomars how can i test an unpublished team on localhost?

You can create a unpublished team by going to step one of create a team -> Then just hit back or navigate back to localhost:3000

sean-brydon avatar Feb 12 '23 22:02 sean-brydon

actually the badge needs to link to stripe not to /teams

we need to replace that @zomars

PeerRich avatar Feb 12 '23 22:02 PeerRich

asked @CarinaWolli to help make a new prop that makes the Upgrade batch link to stripe instead fo /teams

PeerRich avatar Feb 15 '23 12:02 PeerRich

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 210.05 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/event-types 354.68 KB 564.73 KB 161.35% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Feb 15 '23 16:02 github-actions[bot]

@zomars or @alannnc could you check if the upgrade badge is doing what it is supposed to? I don't know how to test that locally and I don't have stripe set up

CarinaWolli avatar Feb 15 '23 20:02 CarinaWolli