cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Feat/custom default video

Open sean-brydon opened this issue 2 years ago • 6 comments

What does this PR do?

Enables the ability for a user to set a default conferencing app for new events

Fixes #5629

https://www.loom.com/share/15c3fc91da714f17b929e5ea5d290c5d

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Chore (refactoring code, technical debt, workflow improvements)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

sean-brydon avatar Feb 09 '23 13:02 sean-brydon

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ❌ Failed (Inspect) Feb 13, 2023 at 10:43PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
ui ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2023 at 10:43PM (UTC)

vercel[bot] avatar Feb 09 '23 13:02 vercel[bot]

Something to consider as well is handling Meet and GCal. What happens if a user disconnects their GCal but has Meet as a default? That means all event types with Meet will fall back to Cal Video without some warning.

joeauyeung avatar Feb 10 '23 01:02 joeauyeung

Something to consider as well is handling Meet and GCal. What happens if a user disconnects their GCal but has Meet as a default? That means all event types with Meet will fall back to Cal Video without some warning.

Is this logic of falling back integrated already? I can for sure add a modal that pops up when disconnecting meet when its your default event type

I know @Jaibles has an idea for the future of being able to batch update settings on all your event types - maybe that can come into play here

-- Edit The logic i implemented here only effects newly created events and not existing (so i guess the for existing events the logic we currently have will apply)

sean-brydon avatar Feb 10 '23 09:02 sean-brydon

@joeauyeung @sean-brydon https://www.loom.com/share/c458cae8932045029c3acdd874648cd7 Installed apps View in Figma

Google Calendar disconnected: Option A - Top Banner persistent across app

ciaranha avatar Feb 10 '23 12:02 ciaranha

This can be handled in another PR right? The current state of handling this is awful.

Big banner that says "You need a google calendar to use google meet " Then below it it says "You have a google calendar connected"

Happy to take them new designs up in this or another PR but i think it should be the latter

sean-brydon avatar Feb 10 '23 12:02 sean-brydon

@sean-brydon I think this is definitely a new pr.

ciaranha avatar Feb 10 '23 12:02 ciaranha