fix(calendar): recurring event fix

[zomars]

trafficstars

From #6732

the loop was running way too often on every recurring object mostly due to the fact that the iterator was not checked for finalization, and in fact the iterator is not implemented correctly so it does not have the done property. instead it checks for undefined or not

also further note, this part is a very slow implementation, which will cause everything to become very slow and practically unusable, there are probably better ways to handle this. Why? well simple, this iterates through every possible day, instead of just applying the current window to it. That means on the one hand this functionality is broken from the first place (b/c it wont work if it is a very long running event) and on the other it was implemented at a very high expense.

--

edit, added at least a start date to the iterator, that should increase the speed of this already.

Signed-off-by: Tobias Gurtzick [email protected]

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
cal	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 10, 2023 at 1:04AM (UTC)
ui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 10, 2023 at 1:04AM (UTC)

[wzrdtales]

so its off the radar again?

[zomars]

@leog Since you made the original implementation for recurring bookings. Can you give this the final test/approval? 🙏🏽

[github-actions[bot]]

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
global	210.36 KB (-1 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/404	8.34 KB	218.69 KB	62.48% (+/- <0.01%)
/[user]	111.13 KB	321.49 KB	91.85% (+/- <0.01%)
/[user]/[type]	99.03 KB	309.39 KB	88.40% (+/- <0.01%)
/[user]/[type]/embed	99.06 KB	309.41 KB	88.40% (+/- <0.01%)
/[user]/embed	111.2 KB	321.56 KB	91.87% (+/- <0.01%)
/apps	170.81 KB	381.17 KB	108.90% (🟡 +0.01%)
/apps/[slug]	194.44 KB	404.79 KB	115.66% (+/- <0.01%)
/apps/categories	155.71 KB	366.07 KB	104.59% (+/- <0.01%)
/apps/categories/[category]	159.58 KB	369.93 KB	105.69% (🟡 +0.01%)
/apps/installed/[category]	198.79 KB	409.15 KB	116.90% (+/- <0.01%)
/auth/error	19.21 KB	229.57 KB	65.59% (+/- <0.01%)
/auth/forgot-password	221.8 KB	432.16 KB	123.47% (+/- <0.01%)
/auth/forgot-password/[id]	40.88 KB	251.23 KB	71.78% (+/- <0.01%)
/auth/login	195.61 KB	405.97 KB	115.99% (+/- <0.01%)
/auth/logout	7.54 KB	217.89 KB	62.26% (+/- <0.01%)
/availability	158.92 KB	369.28 KB	105.51% (+/- <0.01%)
/availability/[schedule]	271.31 KB	481.66 KB	137.62% (+/- <0.01%)
/availability/troubleshoot	156.4 KB	366.75 KB	104.79% (+/- <0.01%)
/booking/[uid]	131.24 KB	341.59 KB	97.60% (+/- <0.01%)
/bookings/[status]	266.07 KB	476.43 KB	136.12% (+/- <0.01%)
/d/[link]/[slug]	98.68 KB	309.04 KB	88.30% (+/- <0.01%)
/d/[link]/[slug]/embed	98.71 KB	309.07 KB	88.30% (🟡 +0.01%)
/event-types	351.72 KB	562.07 KB	160.59% (+/- <0.01%)
/event-types/[type]	384.63 KB	594.99 KB	170.00% (+/- <0.01%)
/more	155.34 KB	365.69 KB	104.48% (+/- <0.01%)
/settings/admin	160.76 KB	371.12 KB	106.03% (+/- <0.01%)
/settings/admin/apps	193.67 KB	404.02 KB	115.43% (+/- <0.01%)
/settings/admin/apps/[category]	193.65 KB	404.01 KB	115.43% (+/- <0.01%)
/settings/admin/impersonation	161.04 KB	371.4 KB	106.11% (+/- <0.01%)
/settings/billing	160.96 KB	371.32 KB	106.09% (+/- <0.01%)
/settings/developer/api-keys	190.03 KB	400.38 KB	114.40% (+/- <0.01%)
/settings/developer/webhooks	163.37 KB	373.72 KB	106.78% (+/- <0.01%)
/settings/developer/webhooks/[id]	192.28 KB	402.64 KB	115.04% (+/- <0.01%)
/settings/developer/webhooks/new	192.14 KB	402.49 KB	115.00% (+/- <0.01%)
/settings/my-account/appearance	174.84 KB	385.2 KB	110.06% (+/- <0.01%)
/settings/my-account/calendars	193.15 KB	403.5 KB	115.29% (+/- <0.01%)
/settings/my-account/conferencing	166.64 KB	377 KB	107.71% (+/- <0.01%)
/settings/my-account/general	266.11 KB	476.46 KB	136.13% (+/- <0.01%)
/settings/security/impersonation	162.91 KB	373.27 KB	106.65% (+/- <0.01%)
/settings/security/password	332.19 KB	542.55 KB	155.01% (+/- <0.01%)
/settings/security/sso	170.59 KB	380.95 KB	108.84% (+/- <0.01%)
/settings/security/two-factor-auth	303.4 KB	513.75 KB	146.79% (+/- <0.01%)
/settings/teams	160.51 KB	370.86 KB	105.96% (+/- <0.01%)
/settings/teams/[id]/appearance	174.86 KB	385.22 KB	110.06% (+/- <0.01%)
/settings/teams/[id]/billing	160.74 KB	371.1 KB	106.03% (+/- <0.01%)
/settings/teams/[id]/members	297.75 KB	508.11 KB	145.17% (+/- <0.01%)
/settings/teams/[id]/profile	273.15 KB	483.51 KB	138.14% (+/- <0.01%)
/settings/teams/[id]/sso	170.68 KB	381.04 KB	108.87% (+/- <0.01%)
/signup	25.42 KB	235.78 KB	67.36% (+/- <0.01%)
/team/[slug]	113.71 KB	324.06 KB	92.59% (+/- <0.01%)
/team/[slug]/[type]	98.68 KB	309.04 KB	88.30% (+/- <0.01%)
/team/[slug]/[type]/embed	98.71 KB	309.07 KB	88.31% (+/- <0.01%)
/team/[slug]/embed	113.77 KB	324.13 KB	92.61% (+/- <0.01%)
/teams	155.55 KB	365.91 KB	104.55% (+/- <0.01%)
/video/meeting-ended/[uid]	22.74 KB	233.1 KB	66.60% (+/- <0.01%)
/video/meeting-not-started/[uid]	22.79 KB	233.15 KB	66.61% (+/- <0.01%)
/video/no-meeting-found	6.95 KB	217.31 KB	62.09% (+/- <0.01%)
/workflows	168.45 KB	378.81 KB	108.23% (+/- <0.01%)
/workflows/[workflow]	296.36 KB	506.72 KB	144.78% (+/- <0.01%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 44 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/10/2023 01:04:07am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 752782480fcbb21805cd5a5be3d900af799dc771

Started: 03/10/2023 12:59:58am UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user can add multiple organizer address Retry 1 • Initial Attempt	15.52% (43) 43 / 277 runs failed over last 7 days	26.35% (73) 73 / 277 runs flaked over last 7 days

---

View Detailed Build Results

---