cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1011] App: File Upload (Starting with Amazon S3)

Open PeerRich opened this issue 2 years ago β€’ 25 comments

starting with S3, organisers can ask guests for a file upload (i.e. a CV or similar)

for security reasons, organisers need to provide their own S3 bucket since Cal.com does not want to host your files

this app would be of type "EventTypeApp"

in event-types:

booking page:

questions:

should this be always optional? or always required? or ability to decide?

From SyncLinear.com | CAL-1011

PeerRich avatar Feb 08 '23 13:02 PeerRich

later: maybe a Google Drive, Dropbox and One Drive as a dropdown select with different options:

CleanShot 2023-02-08 at 14 18 40@2x

PeerRich avatar Feb 08 '23 13:02 PeerRich

alternatively we have one app per service which is probably cleaner (also gives us better insights).

it can have identical implementation too, just duplicated app meta data

PeerRich avatar Feb 08 '23 13:02 PeerRich

one app for Dropbox, one app for Google Drive, etc.

PeerRich avatar Feb 08 '23 13:02 PeerRich

Looks great!

Some suggested subtle UI adjustments. Main things are

  • Check spacing above & below drag and drop area
  • Font-weight inside it
  • Replace blue link colour with a dashed underline since I don't think this needs to be called out with colour.
  • Suggested circle around icon so we can give it more visual weight without having to go so big & bold.
  • Question: Should we add a label to the area so it's consistent with the other inputs? I think it help makes it look more standalone and less apart of the question above it.
CleanShot 2023-02-08 at 14 04 57@2x

https://www.figma.com/file/xk4HOxtSI82J0F7enMxeak/Cal---Live?node-id=2787%3A129690&t=QRzD1Dx5TsLxWmvP-1

ciaranha avatar Feb 08 '23 14:02 ciaranha

cheers!

PeerRich avatar Feb 08 '23 14:02 PeerRich

Should we impose limits? I can see a bot filling up our users buckets with trash data.

zomars avatar Feb 09 '23 19:02 zomars

rate limits, yea. we need to be very careful when we roll this out (if at all. its still in idea stage)

PeerRich avatar Feb 09 '23 20:02 PeerRich

/bounty

PeerRich avatar Feb 12 '23 13:02 PeerRich

πŸ’Ž $300 bounty created by PeerRich πŸ‘‰ No need to comment asking to work on it. Just open a PR and claim the bounty with /claim #6939 inside the PR πŸ“ Before proceeding, please make sure you can receive payouts in your country πŸ’΅ Payment arrives in your account 2-5 days after the bounty is rewarded πŸ’― You keep 100% of the bounty award πŸ™ Thank you for contributing to calcom/cal.com!

algora-pbc[bot] avatar Feb 12 '23 13:02 algora-pbc[bot]

The best win here would be to initially have an S3 compatible support so you'll get things like Backblaze, R2, and so on. Likewise we can have a configurable file limit for the user alongside the in-memory rate limits that we already enforce elsewhere within the application.

Mythie avatar Feb 22 '23 00:02 Mythie

if anyone wants to pick this up, here's how to make an app: https://docs.cal.com/how-to-guides/how-to-build-an-app

PeerRich avatar Feb 22 '23 19:02 PeerRich

Hi everyone!

This would certainly be a very useful app!

I've been looking around to pick this up. IMO this should work along with the recent feature of Booking questions... Do you think this is a good approach? CC @hariombalhara (I noticed that you implemented this πŸ˜…)

miguelnietoa avatar Mar 11 '23 23:03 miguelnietoa

i think it would be nice to add this into booking questions UI but keep it standalone as an app

PeerRich avatar Mar 12 '23 17:03 PeerRich

@miguelnietoa Yeah it fits well into the Booking Questions feature. I would recommend the way we manage smsReminderNumber field/question which is added by workflows in Booking Questions

hariombalhara avatar Mar 13 '23 05:03 hariombalhara

@hariombalhara I think you mean to use the upsertBookingField function as you did with the smsReminderNumber field, right?

Or do you recommend that the app works like webhooks? Because it doesn't really make sense to me via webhooks...

miguelnietoa avatar Mar 13 '23 21:03 miguelnietoa

Yeah I meant upserBookingField only

hariombalhara avatar Mar 14 '23 01:03 hariombalhara

Got it, totally agree with both of you! Excited to work on this @PeerRich πŸš€

miguelnietoa avatar Mar 14 '23 02:03 miguelnietoa

You have a new bid! Click here to see.

algora-pbc[bot] avatar Mar 14 '23 03:03 algora-pbc[bot]

πŸ’Ž $300.00 bounty created by PeerRich after accepting @andresobral's bid πŸ‘‰ To claim this bounty, submit a pull request that includes the text /claim #6939 somewhere in its body πŸ“ To receive payouts, complete Stripe Connect on your Algora dashboard πŸ’΅ Payment arrives in your account 2-5 days after the bounty is rewarded πŸ’― You keep 100% of the bounty award 🌳 If you want, you can donate 100% of the rewards to climate change projects! πŸ™ Thank you for contributing to calcom/cal.com!

algora-pbc[bot] avatar Mar 15 '23 17:03 algora-pbc[bot]

Hey @andresobral, are you currently tackling this issue?

miguelnietoa avatar Mar 18 '23 02:03 miguelnietoa

Hi @miguelnietoa ! Yes, I am on it. I will submit a PR soon. Just to confirm, this should not be a app anymore and it will happen in the booking questions feature, correct?

andresobral avatar Mar 21 '23 19:03 andresobral

i think it would be nice to add this into booking questions UI but keep it standalone as an app

@andresobral No, It should be standalone as an app

miguelnietoa avatar Mar 21 '23 19:03 miguelnietoa

Hey, @andresobral and @miguelnietoa are you guys still working on this? If not can I take a look into this?

joe-shajan avatar May 03 '23 04:05 joe-shajan

Hey @joe-shajan I just came back to work on this haha, since @andresobral didn't create the PR. Anyway, in these days I'll submit it! πŸ˜…

miguelnietoa avatar May 03 '23 04:05 miguelnietoa

can i attempt this ?

Hitesh-Sisara avatar Sep 05 '23 12:09 Hitesh-Sisara

Hey @PeerRich I noticed a pull request. Is this feature still unresolved?

mitibirru avatar Oct 24 '23 20:10 mitibirru

weve decided to not do this right now

PeerRich avatar Oct 25 '23 09:10 PeerRich