calcom
fix: add allowOverflow property
What does this PR do?
Fixes:- all dropdown bugs mentioned here https://threads.com/34443655935?s=mADSwgHK128iEkEZE7JFFU
Follow up :- https://github.com/calcom/cal.com/pull/6587
Environment: Staging(main branch) / Production
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Chore (refactoring code, technical debt, workflow improvements)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated |
|---|---|---|---|---|
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Jan 23, 2023 at 0:45AM (UTC) |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated |
|---|---|---|---|---|
| cal-com-storybook | ⬜️ Ignored (Inspect) | Jan 23, 2023 at 0:45AM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@emrysal should work now. although i agree we will have to remove enableOverflow. I tried fixing react-select using menuPortalTarget but the dropdown was not unscrollable https://github.com/JedWatson/react-select/issues/1085#issuecomment-1348874053
https://user-images.githubusercontent.com/53316345/214043057-62602df8-776d-425d-9173-d605667abacf.mov
btw since when do we add a 1px black border around the dropdown? that's not in the figma cc @Jaibles
@PeerRich @Jaibles it certainly wasn't this way when we launched Date Overrides, UI regression.
@Udit-takkar one of our customers is experiencing this in their routing forms. I'm assuming this will also fix this issue?
Will you ping me when this is in production so I can check with them?
Looking at the code the routing form embed should work after this PR @hariombalhara
@hariombalhara @emrysal A customer is still experiencing this issue - specifically re: my comment above with the screenshot in the routing form. Any ideas how to fix it?