cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Stripe automatic payment method

Open jepek opened this issue 2 years ago • 9 comments

What does this PR do?

  1. Deleting payment_method_types in Stripe Payments lets clients to manage payments methods by them - they know best.
  2. Introducing automatic_payment_methods (see the docs) improves the payment methods - Stripe will automatically propose payment methods based on currency/locale.

Fixes #5263

This video from the Stripe Developers visually shows the difference

Type of change

  • [x] Chore (refactoring code, technical debt, workflow improvements)

Required actions ❗

Let connected accounts manage their payments methods:

Stripe recommends that you allow the owners of your platform’s connected accounts to customize their own payment methods from the Dashboard. If you enable this option, then each Standard connected account can log in to their Dashboard and view their Payment methods page.

Pleas see and follow the instructions here: https://stripe.com/docs/connect/automatic-payment-methods?connect-payment-integration-type=checkout&connect-charge-type=direct&connect-account-type=standard#allow-connected-accounts-manage

How should this be tested?

This changes the flow on the payment page from Stripe.

  • Check if other payment methods are available on payments page of connected account
  • Check if specific payments methods are available on payments page of connected account after customazing them under connected account payment methods

Additional

I wasn't able to publish self hosted version to test the custom payment methods from Stripe (they block it from local) thus preview instance and the change from Required actions would help a lot.

jepek avatar Jan 22 '23 22:01 jepek

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ❌ Failed (Inspect) Feb 8, 2023 at 7:54PM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 7:54PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
cal-com-storybook ⬜️ Ignored (Inspect) Feb 8, 2023 at 7:54PM (UTC)

vercel[bot] avatar Jan 22 '23 22:01 vercel[bot]

@jepek is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 22 '23 22:01 vercel[bot]

hey @jepek, we'll look into this! thank you for the PR

PeerRich avatar Jan 22 '23 23:01 PeerRich

Deployment failed with the following error:

Was unable to schedule a deployment.

vercel[bot] avatar Jan 22 '23 23:01 vercel[bot]

gave permission for a vercel deploymetn

PeerRich avatar Jan 22 '23 23:01 PeerRich

weird. deployment failed

PeerRich avatar Jan 22 '23 23:01 PeerRich

@PeerRich any reason from logs?

jepek avatar Jan 23 '23 10:01 jepek

@PeerRich any reason from logs?

somehow not

PeerRich avatar Jan 23 '23 14:01 PeerRich

@PeerRich I rebased the branch on top of current main branch. Could you please approve the deployment to preview again?

jepek avatar Jan 26 '23 16:01 jepek

Hey @zomars

I see some conflicts now :eyes: Do you have any idea why this fails?

jepek avatar Jan 29 '23 16:01 jepek

Hey @zomars

I am back to the topic as I have another opportunity to integrate cal.com for one of my clients but I need the payment method via Stripe that they provide.

I am not sure if this touches Stripe Checkout feature - I just want to activate one of the payment methods they are providing.

I have tested a few calendar-booking solutions and some of them enable users to control by their own (via their Stripe account) the payment methods, some of them block this and pretend to do it in their behalf (what imo limits the usage) and some just locks the payment methods to the specific one as we have it here "cards" I think. I am sure this is only a matter of configuration because once some payment method is activated Stripe checkout handles that perfectly.

@zomars Can we get back to this? Would be happy to work more on that. The thing that blocked us here was a failing preview branch.

jepek avatar Oct 11 '23 12:10 jepek

@PeerRich / @zomars

Same as @jepek mentioned above, we use Cal.com but are now considering switching over to other competitors because this feature is blocking us. Is this on the roadmap to fix?

rushilsrivastava avatar Jan 11 '24 20:01 rushilsrivastava

Hey, do we have any update on that? I'd like to integrate Polish payments (BLIK etc) but we're getting blocked by this.

davidparys avatar Jan 23 '24 11:01 davidparys

we are looking into this again!

PeerRich avatar Jan 26 '24 11:01 PeerRich