Enabled overriding any day

[emrysal]

What does this PR do?

Stop caring about the workingHours to create a date override.

Resolves #6311 Resolves #6279

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
cal	❌ Failed (Inspect)			Mar 9, 2023 at 0:30AM (UTC)
cal-com-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 9, 2023 at 0:30AM (UTC)

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
ui	⬜️ Ignored (Inspect)	Visit Preview		Mar 9, 2023 at 0:30AM (UTC)

[PeerRich]

wait does this enable adding days? or is that another PR

[mrkirchner]

Whats the progress on this its been open for a while because it may fix a few daylight saving issues.

[emrysal]

@mrkirchner Big push pending finalisation that handles the busyTimes & also the round robin fixed/collective attendees.

[zomars]

Setting these overrides

Works for available to unavailable days but I cannot override unavailable to available days

[grapeslush]

Any target on when this change might get pushed out? Been waiting on a fix for daylight savings issues since Dec or so.

[grapeslush]

Hello, just checking again on this fix. Any updates on next steps?

[mrkirchner]

Any reason why this pr is still open it’s been almost 2 months. A few people have been waiting on to see if it fixes a daylight savings issue.

[emrysal]

Hi @grapeslush @mrkirchner Yeah this PRs been open for a while, I'm working on closing it off this week; the last 3 weeks have been extremely hectic with other critical issues and investigations.

[roae]

I Found this bug,

I disabled all days, then added 3 date overrides, March 13, 14 and 15 on a 9am to 5pm (America/Detroit) schedule.

In the calendar it shows me March 12, 13 and 14 enabled.

[github-actions[bot]]

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Sixty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/[user]	110.97 KB	321.3 KB	91.80% (+/- <0.01%)
/[user]/[type]	98.85 KB	309.17 KB	88.34% (🟢 -0.02%)
/[user]/[type]/embed	98.87 KB	309.2 KB	88.34% (🟢 -0.01%)
/[user]/book	188.14 KB	398.46 KB	113.85% (🟢 -0.01%)
/[user]/embed	111.04 KB	321.37 KB	91.82% (+/- <0.01%)
/apps	170.23 KB	380.55 KB	108.73% (+/- <0.01%)
/apps/[slug]	194.1 KB	404.43 KB	115.55% (+/- <0.01%)
/apps/[slug]/[...pages]	394.7 KB	605.03 KB	172.87% (🟢 -0.01%)
/apps/categories	155.56 KB	365.89 KB	104.54% (+/- <0.01%)
/apps/categories/[category]	158.83 KB	369.15 KB	105.47% (+/- <0.01%)
/apps/installed/[category]	198.3 KB	408.62 KB	116.75% (+/- <0.01%)
/auth/forgot-password	181.32 KB	391.65 KB	111.90% (+/- <0.01%)
/auth/login	195.61 KB	405.94 KB	115.98% (+/- <0.01%)
/auth/setup	242.13 KB	452.46 KB	129.27% (+/- <0.01%)
/availability	158.48 KB	368.81 KB	105.37% (🟢 -0.08%)
/availability/[schedule]	270.63 KB	480.96 KB	137.42% (🟢 -0.15%)
/availability/troubleshoot	156.26 KB	366.59 KB	104.74% (+/- <0.01%)
/booking/[uid]	130.68 KB	341.01 KB	97.43% (🟢 -0.04%)
/bookings/[status]	265.78 KB	476.11 KB	136.03% (🟢 -0.04%)
/d/[link]/[slug]	98.49 KB	308.82 KB	88.23% (🟢 -0.01%)
/d/[link]/[slug]/embed	98.52 KB	308.85 KB	88.24% (🟢 -0.01%)
/d/[link]/book	187.79 KB	398.12 KB	113.75% (+/- <0.01%)
/event-types	351.57 KB	561.9 KB	160.54% (🟡 +0.01%)
/event-types/[type]	384.23 KB	594.56 KB	169.87% (🟢 -0.01%)
/getting-started/[[...step]]	329.02 KB	539.35 KB	154.10% (🟢 -0.09%)
/more	155.19 KB	365.52 KB	104.43% (+/- <0.01%)
/payment/[uid]	68.51 KB	278.84 KB	79.67% (+/- <0.01%)
/settings/admin	160.61 KB	370.94 KB	105.98% (+/- <0.01%)
/settings/admin/apps	193.5 KB	403.83 KB	115.38% (+/- <0.01%)
/settings/admin/apps/[category]	193.49 KB	403.81 KB	115.38% (+/- <0.01%)
/settings/admin/impersonation	160.89 KB	371.22 KB	106.06% (+/- <0.01%)
/settings/billing	160.81 KB	371.14 KB	106.04% (+/- <0.01%)
/settings/developer/api-keys	189.88 KB	400.21 KB	114.34% (+/- <0.01%)
/settings/developer/webhooks	163.22 KB	373.55 KB	106.73% (+/- <0.01%)
/settings/developer/webhooks/[id]	192.13 KB	402.46 KB	114.99% (+/- <0.01%)
/settings/developer/webhooks/new	191.99 KB	402.32 KB	114.95% (+/- <0.01%)
/settings/my-account/appearance	174.66 KB	384.99 KB	110.00% (+/- <0.01%)
/settings/my-account/calendars	193 KB	403.32 KB	115.23% (+/- <0.01%)
/settings/my-account/conferencing	166.48 KB	376.81 KB	107.66% (+/- <0.01%)
/settings/my-account/general	265.96 KB	476.29 KB	136.08% (+/- <0.01%)
/settings/my-account/profile	437.45 KB	647.77 KB	185.08% (+/- <0.01%)
/settings/security/impersonation	162.76 KB	373.09 KB	106.60% (+/- <0.01%)
/settings/security/password	332.05 KB	542.37 KB	154.96% (+/- <0.01%)
/settings/security/sso	170.44 KB	380.77 KB	108.79% (+/- <0.01%)
/settings/security/two-factor-auth	303.25 KB	513.58 KB	146.74% (+/- <0.01%)
/settings/teams	160.36 KB	370.68 KB	105.91% (+/- <0.01%)
/settings/teams/[id]/appearance	174.69 KB	385.02 KB	110.01% (🟢 -0.01%)
/settings/teams/[id]/billing	160.59 KB	370.92 KB	105.98% (+/- <0.01%)
/settings/teams/[id]/members	295.61 KB	505.94 KB	144.55% (🟢 -0.56%)
/settings/teams/[id]/profile	273.08 KB	483.41 KB	138.12% (+/- <0.01%)
/settings/teams/[id]/sso	170.53 KB	380.86 KB	108.82% (+/- <0.01%)
/settings/teams/new	113.31 KB	323.64 KB	92.47% (+/- <0.01%)
/team/[slug]	113.71 KB	324.04 KB	92.58% (+/- <0.01%)
/team/[slug]/[type]	98.5 KB	308.82 KB	88.24% (🟢 -0.02%)
/team/[slug]/[type]/embed	98.53 KB	308.85 KB	88.24% (🟢 -0.01%)
/team/[slug]/book	187.79 KB	398.12 KB	113.75% (+/- <0.01%)
/team/[slug]/embed	113.78 KB	324.11 KB	92.60% (+/- <0.01%)
/teams	155.41 KB	365.74 KB	104.50% (+/- <0.01%)
/workflows	168.3 KB	378.63 KB	108.18% (+/- <0.01%)
/workflows/[workflow]	296.31 KB	506.63 KB	144.75% (+/- <0.01%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

[zomars]

Drafting until DST bug fixes are applied.

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 50 Passing - ❌ 2 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/09/2023 12:44:58am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: c23c0803920fea232f12b9cbc20a9e7e941e319c

Started: 03/09/2023 12:40:09am UTC

❌ Failures

📄   apps/web/playwright/availability.e2e.ts • 2 Failures

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Availablity tests Date Overrides Retry 2 • Retry 1 • Initial Attempt Error: Cannot read properties of undefined (reading 'find') Cannot read properties of undefined (reading 'find')	2.52% (6) 6 / 238 runs failed over last 7 days	1.68% (4) 4 / 238 runs flaked over last 7 days
Availablity tests Availablity pages Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toHaveValue(expected)... expect(received).toHaveValue(expected) Expected string: "More working hours" Received string: "" Call log: - expect.toHaveValue with timeout 10000ms - waiting for selector "[data-testid=availablity-title]" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value "" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value "" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value "" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value "" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value "" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value "" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value "" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value "" - selector resolved to <input value="" name="name" type="text" required="" dat…/> - unexpected value ""	2.10% (5) 5 / 238 runs failed over last 7 days	0% (0) 0 / 238 runs flaked over last 7 days

---

View Detailed Build Results

---

[github-actions[bot]]

This PR is being marked as stale due to inactivity.

[emrysal]

This was the first (failed) attempt, closing; this is implemented now in main - about to go live.