cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Chor/text colors+weights

Open sean-brydon opened this issue 2 years ago • 1 comments

Base all of our styling off html semantics.

Creates a set of tailwind bases for headings and also talwind components (same as old @apply method) for when we need to override styles applied by bases

Main work for this is in packages/config/tailwind-bases.js

Please checkout the storybook instance locally to see the changes.

All h1,h2,h3 have base styles and any additional styling has been removed from them within the app. (I think i have corrected the ones where we have h2s looking like h3s etc

p and small tags have been added with a base style but not changed in the app just yet as this PR would be massive.

.multiline-normal and .multiline-medium have been added in respect to the design system.

sean-brydon avatar Jan 13 '23 11:01 sean-brydon

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
cal ❌ Failed (Inspect) Mar 6, 2023 at 2:29AM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 2:29AM (UTC)

vercel[bot] avatar Jan 13 '23 11:01 vercel[bot]

@Jaibles should we put this on the back burner for now?

sean-brydon avatar Feb 08 '23 12:02 sean-brydon

@sean-brydon maybe a good idea. I don't mind going through it on a call, but right now most places I see headers I see issues - so could be easier to put on the backburner.

Page headers are too big. CleanShot 2023-02-08 at 12 42 05@2x

None of these should be Cal Sans CleanShot 2023-02-08 at 12 41 49@2x

ciaranha avatar Feb 08 '23 12:02 ciaranha

CleanShot 2023-02-08 at 16 48 51@2x

CleanShot 2023-02-08 at 16 48 22@2x

PeerRich avatar Feb 08 '23 15:02 PeerRich

Current Playwright Test Results Summary

✅ 50 Passing - ❌ 3 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 03/04/2023 04:00:49am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: aeb36652dfaad08fae0161534ef7be995b87d90d

Started: 03/04/2023 03:55:27am UTC

❌ Failures

📄   ../tests/action-based.test.ts • 3 Failures

Top 1 Common Error Messages

Expected to provide an iframe, got null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
Error: Expected to provide an iframe, got null
Expected to provide an iframe, got null
54.29% (19) 19 / 35 runs
failed over last 7 days
0% (0) 0 / 35 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
Error: Expected to provide an iframe, got null
Expected to provide an iframe, got null
54.29% (19) 19 / 35 runs
failed over last 7 days
0% (0) 0 / 35 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
Error: Routing Form embed iframe not found
Routing Form embed iframe not found
51.43% (18) 18 / 35 runs
failed over last 7 days
0% (0) 0 / 35 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Mar 04 '23 04:03 deploysentinel[bot]

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 210.39 KB (🟡 +131 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seventy Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 8.33 KB 218.72 KB 62.49% (+/- <0.01%)
/500 5.95 KB 216.33 KB 61.81% (+/- <0.01%)
/[user] 110.93 KB 321.31 KB 91.80% (🟢 -0.01%)
/[user]/[type] 99.32 KB 309.7 KB 88.49% (🟢 -0.01%)
/[user]/[type]/embed 99.35 KB 309.73 KB 88.50% (🟢 -0.01%)
/[user]/book 187.85 KB 398.23 KB 113.78% (🟢 -0.02%)
/[user]/embed 110.99 KB 321.38 KB 91.82% (🟢 -0.01%)
/apps 169.84 KB 380.23 KB 108.64% (🟢 -0.02%)
/apps/[slug] 193.72 KB 404.11 KB 115.46% (🟢 -0.02%)
/apps/[slug]/[...pages] 394.28 KB 604.67 KB 172.76% (🟢 -0.02%)
/apps/categories 155.19 KB 365.58 KB 104.45% (🟢 -0.01%)
/apps/categories/[category] 158.48 KB 368.86 KB 105.39% (🟢 -0.01%)
/apps/installed/[category] 196.52 KB 406.91 KB 116.26% (🟢 -0.03%)
/auth/error 19.19 KB 229.57 KB 65.59% (+/- <0.01%)
/auth/forgot-password 181.3 KB 391.69 KB 111.91% (+/- <0.01%)
/auth/forgot-password/[id] 40.84 KB 251.23 KB 71.78% (+/- <0.01%)
/auth/login 195.59 KB 405.97 KB 115.99% (+/- <0.01%)
/auth/logout 7.51 KB 217.89 KB 62.26% (🟢 -0.01%)
/auth/setup 242.1 KB 452.48 KB 129.28% (🟢 -0.01%)
/auth/verify 18.17 KB 228.56 KB 65.30% (+/- <0.01%)
/availability 158.41 KB 368.79 KB 105.37% (🟢 -0.01%)
/availability/[schedule] 271.19 KB 481.58 KB 137.59% (🟢 -0.01%)
/availability/troubleshoot 155.89 KB 366.28 KB 104.65% (🟢 -0.01%)
/booking/[uid] 129.96 KB 340.35 KB 97.24% (+/- <0.01%)
/bookings/[status] 265.54 KB 475.92 KB 135.98% (🟢 -0.01%)
/d/[link]/[slug] 98.98 KB 309.36 KB 88.39% (🟢 -0.01%)
/d/[link]/[slug]/embed 99.01 KB 309.39 KB 88.40% (🟢 -0.01%)
/d/[link]/book 187.51 KB 397.89 KB 113.68% (🟢 -0.01%)
/event-types 351.19 KB 561.57 KB 160.45% (🟢 -0.02%)
/event-types/[type] 384.22 KB 594.61 KB 169.89% (🟢 -0.02%)
/getting-started/[[...step]] 329.04 KB 539.42 KB 154.12% (🟢 -0.01%)
/more 154.83 KB 365.21 KB 104.35% (🟢 -0.01%)
/settings/admin 160.24 KB 370.63 KB 105.89% (🟢 -0.01%)
/settings/admin/apps 193.12 KB 403.51 KB 115.29% (🟢 -0.02%)
/settings/admin/apps/[category] 193.11 KB 403.49 KB 115.28% (🟢 -0.02%)
/settings/admin/impersonation 160.53 KB 370.91 KB 105.98% (🟢 -0.02%)
/settings/billing 160.43 KB 370.81 KB 105.95% (🟢 -0.02%)
/settings/developer/api-keys 189.48 KB 399.87 KB 114.25% (🟢 -0.03%)
/settings/developer/webhooks 162.85 KB 373.24 KB 106.64% (🟢 -0.02%)
/settings/developer/webhooks/[id] 191.79 KB 402.17 KB 114.91% (🟢 -0.02%)
/settings/developer/webhooks/new 191.65 KB 402.03 KB 114.87% (🟢 -0.02%)
/settings/my-account/appearance 174.3 KB 384.68 KB 109.91% (🟢 -0.02%)
/settings/my-account/calendars 192.64 KB 403.03 KB 115.15% (🟢 -0.02%)
/settings/my-account/conferencing 164.67 KB 375.06 KB 107.16% (🟢 -0.02%)
/settings/my-account/general 265.34 KB 475.72 KB 135.92% (🟢 -0.01%)
/settings/my-account/profile 437.08 KB 647.46 KB 184.99% (🟢 -0.02%)
/settings/security/impersonation 162.39 KB 372.78 KB 106.51% (🟢 -0.02%)
/settings/security/password 331.69 KB 542.07 KB 154.88% (🟢 -0.02%)
/settings/security/sso 170.06 KB 380.44 KB 108.70% (🟢 -0.02%)
/settings/security/two-factor-auth 302.88 KB 513.27 KB 146.65% (🟢 -0.02%)
/settings/teams 159.99 KB 370.37 KB 105.82% (🟢 -0.01%)
/settings/teams/[id]/appearance 174.32 KB 384.71 KB 109.92% (🟢 -0.02%)
/settings/teams/[id]/billing 160.21 KB 370.6 KB 105.88% (🟢 -0.01%)
/settings/teams/[id]/members 296.92 KB 507.3 KB 144.94% (🟢 -0.01%)
/settings/teams/[id]/onboard-members 74.06 KB 284.45 KB 81.27% (+/- <0.01%)
/settings/teams/[id]/profile 272.71 KB 483.09 KB 138.03% (🟢 -0.02%)
/settings/teams/[id]/sso 170.16 KB 380.54 KB 108.73% (🟢 -0.02%)
/settings/teams/new 113.25 KB 323.64 KB 92.47% (🟢 -0.01%)
/signup 25.39 KB 235.77 KB 67.36% (+/- <0.01%)
/team/[slug] 113.68 KB 324.07 KB 92.59% (+/- <0.01%)
/team/[slug]/[type] 98.98 KB 309.36 KB 88.39% (🟢 -0.01%)
/team/[slug]/[type]/embed 99.01 KB 309.39 KB 88.40% (🟢 -0.01%)
/team/[slug]/book 187.51 KB 397.9 KB 113.68% (🟢 -0.01%)
/team/[slug]/embed 113.75 KB 324.14 KB 92.61% (+/- <0.01%)
/teams 155.05 KB 365.43 KB 104.41% (🟢 -0.01%)
/video/meeting-ended/[uid] 22.71 KB 233.1 KB 66.60% (🟢 -0.01%)
/video/meeting-not-started/[uid] 22.76 KB 233.14 KB 66.61% (🟢 -0.01%)
/video/no-meeting-found 6.93 KB 217.32 KB 62.09% (+/- <0.01%)
/workflows 167.92 KB 378.31 KB 108.09% (🟢 -0.02%)
/workflows/[workflow] 295.95 KB 506.33 KB 144.67% (🟢 -0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Mar 04 '23 04:03 github-actions[bot]

Gonna put this on hold for a bit - needs some re-consideration

sean-brydon avatar Mar 06 '23 02:03 sean-brydon

yeah lets move forward with dark: for now

PeerRich avatar Mar 06 '23 13:03 PeerRich