cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-670] Incorrect SkeletonLoaders

Open sean-brydon opened this issue 2 years ago • 8 comments

CleanShot 2023-01-03 at 11.34.22@2x.png

Lots of places in the app are using the skeleton loader that is exported from apps. This is the incorrect design and doesn't match the UI that is being loaded.

From SyncLinear.com | CAL-670

sean-brydon avatar Jan 03 '23 11:01 sean-brydon

I'd like to work on this, could you give a better description?

draqist avatar Mar 13 '23 19:03 draqist

Can you assign this task to me?

0xRajvardhan avatar Apr 01 '23 05:04 0xRajvardhan

Can you assign this task to me?

Are you working on this issue rn.

gambhirsharma avatar Apr 29 '23 16:04 gambhirsharma

@sean-brydon is it still open? i could like to contribute. can you assign it to me?

virinchimanepalli avatar Apr 30 '23 11:04 virinchimanepalli

Hi @virinchimanepalli I'm going to pass this issue to @gambhirsharma since he was interested before you - please tag me in any other issues you fancy and i will assign <3

sean-brydon avatar Apr 30 '23 11:04 sean-brydon

Hey! @sean-brydon can you please provide more detail on this issue?

gambhirsharma avatar May 01 '23 05:05 gambhirsharma

whoever is interested just raise a PR, no need to be assigned first

PeerRich avatar May 17 '23 18:05 PeerRich

@sean-brydon, Could you please specify the pages in the app where the incorrect SkeletonLoader is being used and doesn't match the loaded UI? This will help us investigate and address the issue more effectively. Any additional details you can provide would be greatly appreciated. Thanks!

Jainex17 avatar May 22 '23 16:05 Jainex17

@sean-brydon, I think this was fixed since I can't find any SkeletonLoaders with similar imports, as mentioned in the screenshot of the issue. For example, this is the screenshot of the current state of the same file, and it is being imported correctly.

So, the issue should be closed.

cc: @PeerRich

Screenshot 2023-06-11 at 19 10 00

JaideepGuntupalli avatar Jun 11 '23 13:06 JaideepGuntupalli

@sean-brydon, I think this was fixed since I can't find any SkeletonLoaders with similar imports, as mentioned in the screenshot of the issue. For example, this is the screenshot of the current state of the same file, and it is being imported correctly.

So, the issue should be closed.

cc: @PeerRich Screenshot 2023-06-11 at 19 10 00

Thank you

sean-brydon avatar Jun 11 '23 13:06 sean-brydon