cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fixes available times overflow bug on safari

Open phishy opened this issue 2 years ago • 1 comments
trafficstars

What does this PR do?

Fixes overflow bug on Safari, where there was too much space between available times.

Fixes #6201

Environment: Production

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Make an event type with a duration of 90 minutes
  • Load in mobile Safari or desktop safari in really small window
  • Notice that the space between available times is back to normal

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

phishy avatar Dec 28 '22 18:12 phishy

@phishy is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 28 '22 18:12 vercel[bot]

@Udit-takkar and now?

phishy avatar Jan 03 '23 02:01 phishy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jan 3, 2023 at 11:13AM (UTC)

vercel[bot] avatar Jan 03 '23 11:01 vercel[bot]

tested, seems to work. waiting for @Udit-takkar's re-review

PeerRich avatar Jan 03 '23 13:01 PeerRich

🙏 It works fine now. just one thing grid-cols-1 and gap-x-2 aren't necessary now as you have removed grid.

Ah yeah. I thought I had removed grid-cols-1. Nice catch on gap-x-2. I'll push it now.

phishy avatar Jan 03 '23 20:01 phishy