cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

yarn dx uses old "docker-compose" instead of current "docker compose"

Open minnixtx opened this issue 2 years ago • 1 comments

Found a bug? Please fill out the sections below. 👍

Issue Summary

When creating the initial database user using yarn dx, you will get an error about docker-compose. This is because current docker uses the syntax docker "space" compose, no hyphen.

Steps to Reproduce

At https://github.com/calcom/cal.com#quick-start-with-yarn-dx is where the instructions are located.

Any other relevant information. For example, why do you consider this a bug and what did you expect to happen instead?

Technical details

This is on a vanilla Debian server with newest version of docker installed. It is a syntax issue though, not a hardware issue.

minnixtx avatar Dec 01 '22 08:12 minnixtx

@zomars i think i had a similar issue

PeerRich avatar Dec 02 '22 10:12 PeerRich

is there any downside in docker-compose"?

PeerRich avatar Jan 25 '23 15:01 PeerRich

closing unless there is a huge downside

PeerRich avatar Jan 25 '23 15:01 PeerRich

@PeerRich, I think this should be reopened.

is there any downside in docker-compose"?

I think so. docker-compose(V1) is deprecated in favor of docker compose(V2-VX). From docker's blog

We’ve now marked Compose V1 as deprecated. Only high-priority security patches and critical bug fixes will apply to V1 until the next milestone.

I'm very interested in the project, but I had this issue when setup locally, so I would love to create a PR to fix it.

renancleyson-dev avatar Feb 13 '23 15:02 renancleyson-dev

is this fix only changing docker-compose to docker compose? maybe @krumware knows more

PeerRich avatar Feb 13 '23 20:02 PeerRich

docker-compose and docker compose are now two different binaries, and the old docker-compose can still be installed separately. But docker compose (with the space) is the way to move forward, and probably works out-of-the-box here.

NOTE: (does not affect this particular method of running, because yarn dx is a convenience for running a local database in this case) Because we require database access at build time, and the newer version of docker compose uses buildkit, which changes features related to build-time networking, building the front-end with docker compose recommends the DOCKER_BUILDKIT=0 env variable in order to use the legacy builder.

krumware avatar Feb 13 '23 21:02 krumware